Control: tags -1 + pending
On Sat, 2016-05-14 at 17:49 +0100, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
>
> On Sun, 2016-04-24 at 17:47 -0400, Doug Torrance wrote:
> > In March 2016, Yahoo! changed their weather API in a non-backwards
> > compatible
> > way. This made wmforecast, a Window Maker dockapp which relies on this API
> > to display weather information, nonfunctional.
> >
> > A new release, version 0.10, was prepared to fix this problem, and
> > additional
> > improvements were made in 0.11, now available in stretch.
> >
> > However, jessie still has version 0.8. I have backported the appropriate
> > changes from 0.10 and 0.11 into a small patch which makes version 0.8
> > functional. I would like to propose that the jessie wmforecast package be
> > updated with these changes.
>
> ++ url = wstrdup("https://query.yahooapis.com/v1/public/yql?q=";
> ++ "select%20*%20from%20weather.forecast%20where%20woeid");
> + if (strcmp(prefs->woeid_or_zip,"w") == 0) {
> +- url = wstrappend(url,"&w=");
> ++ url = wstrappend(url, "%20%3D%20");
> + url = wstrappend(url, prefs->woeid);
> + }
> + else {
> +- url = wstrappend(url,"&p=");
> ++ url = wstrappend(url, "%20in%20(select%20woeid%20from%20"
> ++ "geo.places(1)%20where%20text%3D%22");
>
> I really do hope the API isn't just literally executing those strings...
>
> Please go ahead.
Uploaded and flagged for acceptance.
Regards,
Adam
