Control: tags -1 - patch On Mon, 4 Aug 2014 14:52:07 +0200 Raphael Hertzog <hert...@debian.org> wrote:
> Control: tags -1 patch
>
> Hello Neil,
>
> On Sun, 03 Aug 2014, Neil Williams wrote:
> > I've now been able to test django-restricted-resource against
> > django1.7 and what I thought should be a simple test has shown
> > significant issues.
> >
> > The changes in django1.7 cause breakage in the
> > django-restricted-resource testsuite and there will be insufficient
> > time to fix the test suite (and likely the packages which depend on
> > django-restricted-resource) ahead of the Jessie freeze.
>
> Really?
>
> I looked into your package. It needs a 3 line patch for the testsuite:
Fixing the testsuite is only one part of it. Checking that the actual
module works with reverse dependencies is where I expect to need the
time. Thanks for the tip though, it does help me start on the package
itself.
A patch which only affects the testsuite isn't going to help packages
using the module.
This also doesn't help django-testscenarios which leads me to think
that this patch is actually against the wrong package (as
django-testscenarios fails the same way and django-restricted-resource
pulls in django-testscenarios).
> $ git diff
> diff --git a/django_restricted_resource/tests.py
> b/django_restricted_resource/tests.py index 8dd1d91..5619eb0 100644
> --- a/django_restricted_resource/tests.py
> +++ b/django_restricted_resource/tests.py
> @@ -34,6 +34,10 @@ from django_restricted_resource.test_utils import (
>
> from django_restricted_resource.models import RestrictedResource
>
> +import django
> +if hasattr(django, 'setup'):
> + django.setup()
> +
>
> class ResourceCleanTests(FixtureHelper, TestCase):
>
>
> And now:
> $ ./setup.py test
> Ran 172 tests in 1.737s
>
> OK
> Destroying test database for alias 'default' (':memory:')...
>
> > Please do not upload django1.7 to unstable at this time.
>
> Please do not pretend you have done a serious investigation when you
> haven't.
I am now very short of time for a serious investigation before October.
The issues with django-testscenarios and django-restricted-resource
also block any fixes for lava-server.
--
Neil Williams
=============
http://www.linux.codehelp.co.uk/
signature.asc
Description: PGP signature
