Hi Julien, Am 26.11.2012 13:35, schrieb Julien Cristau: > On Mon, Nov 26, 2012 at 10:26:28 +0100, Micha Lenk wrote: > >> Hi Adam, >> >> On 11/25/2012 09:41 PM CEST +02:00, Adam D. Barratt wrote: >>> On Fri, 2012-11-23 at 21:52 +0100, Micha Lenk wrote: >>>> This release fixes Debian bug #688831, symlinks in package >>>> libaqbanking34-dev pointing to non-existent files (a policy violation). >>>> Additionally I changed debian/rules so that it injects build flags from >>>> dpkg-buildflags to support the Security Hardening Build Flags, a release >>>> goal. >>> >>> Was the hardening change requested by the Security Team? I'm somewhat >>> wary of build-time changes to libraries with reverse dependencies at >>> this point. >> >> No, it wasn't. It was just a low hanging fruit, I thought. >> >> If you feel uncomfortable with the hardening change, I can upload again >> with the hardening change reverted. >> > Yes please.
I've just uploaded libaqbanking 5.0.24-3 that has the hardening change reverted. Please see the attached diff to the version 5.0.24-1 currently available in testing. Regards, Micha
diff -Nru libaqbanking-5.0.24/debian/changelog libaqbanking-5.0.24/debian/changelog --- libaqbanking-5.0.24/debian/changelog 2012-06-03 20:13:45.000000000 +0200 +++ libaqbanking-5.0.24/debian/changelog 2012-12-09 13:43:14.000000000 +0100 @@ -1,3 +1,19 @@ +libaqbanking (5.0.24-3) unstable; urgency=low + + * Revert injection of build flags from dpkg-buildflags, as requested by the + release team. + + -- Micha Lenk <mi...@debian.org> Sun, 09 Dec 2012 13:42:14 +0100 + +libaqbanking (5.0.24-2) unstable; urgency=low + + * Don't ship symlink /usr/lib/libaqbankingpp.so as we don't ship its + destination libaqbankingpp.so.0.0.0 (closes: #688831). + * Inject build flags from dpkg-buildflags, enabling support for the Security + Hardening Build Flag release goal. + + -- Micha Lenk <mi...@debian.org> Mon, 12 Nov 2012 21:59:15 +0100 + libaqbanking (5.0.24-1) unstable; urgency=low * New upstream release diff -Nru libaqbanking-5.0.24/debian/rules libaqbanking-5.0.24/debian/rules --- libaqbanking-5.0.24/debian/rules 2012-06-03 19:22:11.000000000 +0200 +++ libaqbanking-5.0.24/debian/rules 2012-12-09 13:43:14.000000000 +0100 @@ -42,6 +42,7 @@ # Remove .la files for shared plugin libraries find $(CURDIR)/debian/tmp/usr/lib/gwenhywfar/plugins -name \*.la -exec rm -v \{\} \; find $(CURDIR)/debian/tmp/usr/lib/aqbanking/plugins -name \*.la -exec rm -v \{\} \; + rm -vf $(CURDIR)/debian/tmp/usr/lib/libaqbankingpp.so override_dh_strip: dh_strip --dbg-package=libaqbanking34-dbg