Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package sysprof (explain the reason for the unblock here) This request is in regard to debian bug #692372. As mentioned in the bug report, sysprof version 1.1.8 reads the CRC checksum of separated debug symbols (in /usr/lib/debug/) incorrectly. This results in it not using the debug symbols at all. (include/attach the debdiff against the package in testing) debdiff attached. unblock sysprof/1.1.8-1 -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (100, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.6-trunk-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru sysprof-1.1.8/debian/changelog sysprof-1.1.8/debian/changelog --- sysprof-1.1.8/debian/changelog 2011-07-26 12:56:29.000000000 +0530 +++ sysprof-1.1.8/debian/changelog 2012-11-07 01:13:49.000000000 +0530 @@ -1,3 +1,10 @@ +sysprof (1.1.8-2) unstable; urgency=low + + * [8b4a245] Add patch to correctly read debug symbols. + Thanks to Simon McVittie (Closes: #692372) + + -- Ritesh Raj Sarraf <r...@debian.org> Wed, 07 Nov 2012 01:12:56 +0530 + sysprof (1.1.8-1) unstable; urgency=low * New upstream release (Closes: #634014) diff -Nru sysprof-1.1.8/debian/patches/series sysprof-1.1.8/debian/patches/series --- sysprof-1.1.8/debian/patches/series 2011-07-26 12:56:29.000000000 +0530 +++ sysprof-1.1.8/debian/patches/series 2012-11-07 01:13:49.000000000 +0530 @@ -1 +1,2 @@ +sysprof-debug-link.patch Don-t-install-udev-rule.patch diff -Nru sysprof-1.1.8/debian/patches/sysprof-debug-link.patch sysprof-1.1.8/debian/patches/sysprof-debug-link.patch --- sysprof-1.1.8/debian/patches/sysprof-debug-link.patch 1970-01-01 05:30:00.000000000 +0530 +++ sysprof-1.1.8/debian/patches/sysprof-debug-link.patch 2012-11-07 01:13:49.000000000 +0530 @@ -0,0 +1,30 @@ +From e9eb5ae3ae1eee52e88eef68a5b0ea09687db020 Mon Sep 17 00:00:00 2001 +From: Pauli Nieminen <suok...@gmail.com> +Date: Mon, 09 Apr 2012 18:13:00 +0000 +Subject: Fix debug link crc reading + +Debug link crc values is strored after null terminated string in 4 +aligned offset. But sysprof was only taking into accoutn alignment +that made elf parser read wrong crc from the debug link string. + +Fix is simple check for string length and adding the length to offset +before alignment. + +Signed-off-by: Pauli Nieminen <suok...@gmail.com> +--- +diff --git a/elfparser.c b/elfparser.c +index 09f08f5..d10fce7 100644 +--- a/elfparser.c ++++ b/elfparser.c +@@ -744,7 +744,8 @@ elf_parser_get_debug_link (ElfParser *parser, guint32 *crc32) + + if (crc32) + { +- offset = (offset + 3) & ~0x3; ++ int len = strlen (result) + 1; ++ offset = (offset + len + 3) & ~0x3; + + *crc32 = GET_UINT32 (parser, offset); + } +-- +cgit v0.9.0.2