On 07/10/2012 16:25, Lior Kaplan wrote: > On Sun, Oct 7, 2012 at 3:34 PM, Mehdi Dogguy <me...@dogguy.org > <mailto:me...@dogguy.org>> wrote: > > I couldn't judge by looking at the diff because the top-directory in > the sources is versioned :/ Could you please provide a sensible diff > between the two version (patches applied)? > > > I haven't applied any patches of my own, just took upstream > maintenance releases. > > Regarding the Debian package, only the changelog was chnaged: > > $ debdiff php-apc_3.1.10-1.dsc php-apc_3.1.13-1.dsc | grep +++ | > grep debian +++ php-apc-3.1.13/debian/changelog 2012-09-04 > 20:01:26.000000000 +0300 > > Regarding upstream, see the attached diff between 3.1.10 to 3.1.13. >
Thanks. Looking at the provided diff, I've found for example: +#ifdef ZEND_ENGINE_2_4 + case IS_CALLABLE: + /* XXX implement this */ + assert(0); + break; +#endif I'd rather avoid it. Moreover, most changes are put under an "#ifdef ZEND_ENGINE_2_4" while php5-dev (afaics) defines ZEND_ENGINE_2. So, as far as I can tell, this release won't add much for Debian. (Please tell me if I got something wrong). Based on that, I'd prefer to keep current wheezy's version unchanged. Instead of accepting php-apc/3.1.13-1, did you want to include targeted fixes in Wheezy? If not, I think I'd close this bugreport. Regards and thanks for your work! -- Mehdi Dogguy مهدي الدڤي -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5071a357.8050...@dogguy.org
