On Thu, May 12, 2011 at 02:12:09PM +0100, Roger Leigh wrote: > On Thu, May 12, 2011 at 02:09:10PM +0100, Roger Leigh wrote: > > Hi, > > > > I was informed today that dchroot-dsa was non-functional in stable, > > and the same bug is also present in unstable. I filed this as > > #626503. The patch is a one-liner to fix a regression in the > > dchroot.conf conffile loading (the interface changed incompatibly > > prior to squeeze being released, and this code is still using the > > older interface, which results in a fatal exception being thrown). > > > > dchroot-dsa can load both dchroot.conf for compatibility, and > > schroot.conf; presumably testing was with schroot.conf only which > > is why this was not picked up prior to release. > > > > Would it be OK to upload a fixed version of the schroot package > > to stable-proposed-updated containing just this one line fix?
See http://git.debian.org/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-squeeze (top two commits for upload are below) diff --git a/bin/dchroot-dsa/dchroot-dsa-main.cc b/bin/dchroot-dsa/dchroot-dsa-main.cc index c2aa219..86e127d 100644 --- a/bin/dchroot-dsa/dchroot-dsa-main.cc +++ b/bin/dchroot-dsa/dchroot-dsa-main.cc @@ -61,7 +61,7 @@ main::load_config () this->config = sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config); if (this->options->load_chroots == true) - this->config->add(DCHROOT_CONF, false); + this->config->add("chroot", DCHROOT_CONF); } else { diff --git a/debian/changelog b/debian/changelog index fb72ab5..0c422f4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +schroot (1.4.19-1+squeeze1) stable-proposed-updates; urgency=low + + * dchroot-dsa: Use current interface for loading dchroot.conf, + rather than the old, which caused a fatal exception + (Closes: #626503). + + -- Roger Leigh <rle...@debian.org> Thu, 12 May 2011 14:31:01 +0100 + schroot (1.4.19-1) unstable; urgency=low * New upstream stable release. -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
