On Thu, 23 Dec 2010 15:56:00 +0100, Mehdi Dogguy <me...@dogguy.org> wrote: > On 17/12/2010 18:10, micah anderson wrote: > > > > Hi Mehdi, > > > >> I'm not decided yet if I'll unblock the package (because I didn't finish > >> the > >> review yet) but I noticed something (that looks) odd (to me) in the Depends > >> field. So, facter depends on: > >> > >> Depends: ruby1.8 (>= 1.8.7.72-3lenny1), net-tools, bind9-host | host, > >> libopenssl-ruby1.8 | libopenssl-ruby1.9 > >> > >> Why does it depend on "libopenssl-ruby1.8 | libopenssl-ruby1.9" when > >> it has a strong dependency on ruby1.8? I tend to think that putting > >> "libopenssl-ruby1.9" as an alternative dependency is wrong in this > >> case. (icbw though) > > > > Facter will work with either ruby1.8 or ruby1.9, and its associated > > libraries, but because ruby1.9 had not settled, we did not include a > > potential depdency on 'ruby1.9'. You are right that its a little > > strange, and probably removing libopenssl-ruby1.9 from the Depends would > > resolve that. > > > > Please remove it.
Did it. > > > A couple minor issues related to this, the changelog entry: > > > > * Add versioned dependency for ruby1.8 (Closes: #585867) > > > > is repeated twice in the upload that I did (oops), and the bug number is > > wrong, it should be #545867. These are pretty minor, but I am happy to > > fix them in an upload, if you would prefer? > > > > Go ahead. Fixed up the changelog, and uploaded 1.5.7-3. micah
pgp7MqPOsPACg.pgp
Description: PGP signature
