Hi Mehdi I'm now re-requesting to unblock vzctl.
I have uploaded an updated version with a correction to the problem you noted. This correction was not enough though. So I have applied a few more things. 1) The init script return with error 1 when already started or already stopped. This makes the debian postinst and prerm scripts to fail. 2) The status command fails. 3) The start-stop-daemon is called with wrong arguments. I have applied a patch that solve these problems. They are all critical issues as I understand it. This is now also reported upstream to be included there. http://bugzilla.openvz.org/show_bug.cgi?id=1685 vzctl (3.0.24-9) unstable; urgency=high * Correction of the solution of #600455 in last upload. Applied patch from upstream. Thanks to Kir Kolyshkin <k...@openvz.org> for fast support. This patch allows vzeventd to be started. * Addtional corrections for vzeventd init function: Makes sure that init script do not return error when already started. Make sure the mandatory status command works. The start-stop-daemon was called with wrong arguments. Fixed now. -- Ola Lundqvist <o...@debian.org> Fri, 29 Oct 2010 18:02:11 +0200 Thanks in advance, // Ola On Fri, Oct 29, 2010 at 07:07:32PM +0200, Ola Lundqvist wrote: > Hi Kir > > When I tested this it was obvious that this did not work as well as it should. > I have applied two more patches to make it work as it should. This problem > must > have been masked by the other problem. > > A bugreport will be sent shortly. > > Best regards, > > // Ola > > On Fri, Oct 29, 2010 at 05:09:03PM +0400, Kir Kolyshkin wrote: > > Mehdi, > > > > Thanks for reporting that! It's my bug :( and I am also unsure > > how this went unnoticed. > > > > Fixed in vzctl git: > > http://git.openvz.org/?p=vzctl;a=commit;h=3527cc269bb51d48e0f511fbf7a807ad56c223d5 > > > > On 10/29/2010 04:16 PM, Ola Lundqvist wrote: > >> Hi Mehdi > >> > >> Thanks. Will upload a new corrected version now. > >> > >> It was tested, but for some reason I did not catch this one. > >> > >> Best regards, > >> > >> // Ola > >> > >> Quoting "Mehdi Dogguy" <me...@dogguy.org>: > >>> On 29/10/2010 07:19, Ola Lundqvist wrote: > >>>> Hi Release team > >>>> > >>>> I (with help of others) have corrected a number of important bugs > >>>> and one > >>>> release critial issue for the vzctl package. You can see the > >>>> changes below. > >>>> > >>> > >>> There is: > >>> > >>> --- vzctl-3.0.24/etc/init.d/initd-functions.in > >>> +++ vzctl-3.0.24/etc/init.d/initd-functions.in > >>> @@ -85 +85,26 @@ > >>> +vzdaemon_start() > >>> +{ > >>> + case DISTR in > >>> > >>> I guess you meant "case $DISTR in"? > >>> I do wonder if this code was tested… > >>> > >>> vzdaemon_stop suffers from the same typo, fwiw. > >>> > >>>> > >>>> I consider all the above important for the next stable release. > >>>> The only one that is more on a "good to have" basis is #597555 but I > >>>> still consider that as important to avoid potential data corruption. > >>>> > >>> > >>> I consider the above as critical. > >>> > >>> Regards, > >>> > >>> -- > >>> Mehdi Dogguy مهدي الدڤي > >>> http://dogguy.org/ > >>> > >>> > >> > >> > >> > > > > > > -- > --- Inguza Technology AB --- MSc in Information Technology ---- > / o...@inguza.com Annebergsslingan 37 \ > | o...@debian.org 654 65 KARLSTAD | > | http://inguza.com/ Mobile: +46 (0)70-332 1551 | > \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / > --------------------------------------------------------------- > -- --- Inguza Technology AB --- MSc in Information Technology ---- / o...@inguza.com Annebergsslingan 37 \ | o...@debian.org 654 65 KARLSTAD | | http://inguza.com/ Mobile: +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101029193523.ga1...@inguza.net
