Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: freeze-exception
Hi, Please unblock package dma IMHO, bug #599172, which makes dma-migrate simply not run on PowerPC and possibly other architectures with unsigned char by default, just might be serious enough to warrant fixing during the freeze. I'm attaching a debdiff for the next (not yet uploaded) revision of the Debian dma package; if I'm reading the protocol right, I'm not supposed to upload it to unstable unless you give me permission to, and say you'll allow it to trickle down into testing :) The diff is quite trivial - basically a char to int conversion for a variable used to hold the getopt(3) return value. As I said in the bug comments itself, this is a mistake I hadn't made for the past well nigh ten years; quite embarrassing :/ So... should I upload -4 to fix it, or is it too late now? :) Thanks in advance for your time, and keep up the great work! unblock dma/0.0.2010.06.17-4 -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'oldstable'), (500, 'stable') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash
diffstat for dma-0.0.2010.06.17-4 changelog | 8 ++++++++ control | 4 ++-- migrate/dma-migrate.c | 4 +++- 3 files changed, 13 insertions(+), 3 deletions(-) diff -Nru dma-0.0.2010.06.17/debian/changelog dma-0.0.2010.06.17/debian/changelog --- dma-0.0.2010.06.17/debian/changelog 2010-07-27 13:34:28.000000000 +0300 +++ dma-0.0.2010.06.17/debian/changelog 2010-10-06 17:30:31.000000000 +0300 @@ -1,3 +1,11 @@ +dma (0.0.2010.06.17-4) unstable; urgency=low + + * Fix an infinite loop in dma-migrate if char is unsigned. + Closes: #599172 + * Switch to Git and point the Vcs-* fields to Gitorious. + + -- Peter Pentchev <r...@ringlet.net> Wed, 06 Oct 2010 17:30:29 +0300 + dma (0.0.2010.06.17-3) unstable; urgency=low * Update the debconf translations: diff -Nru dma-0.0.2010.06.17/debian/control dma-0.0.2010.06.17/debian/control --- dma-0.0.2010.06.17/debian/control 2010-07-27 13:12:22.000000000 +0300 +++ dma-0.0.2010.06.17/debian/control 2010-10-06 17:21:05.000000000 +0300 @@ -6,8 +6,8 @@ Build-Depends: debhelper (>= 7.0.50), byacc, dpkg-dev (>= 1.15.7~), flex, hardening-wrapper, liblockfile-dev, libssl-dev, po-debconf Standards-Version: 3.9.1 Homepage: http://devel.ringlet.net/mail/dma/ -Vcs-Svn: http://svn.ringlet.net/svn/ringlet/mail/dma/trunk/dma-pkg/debian/ -Vcs-Browser: http://svn.ringlet.net/v/ringlet/mail/dma/trunk/dma-pkg/debian/ +Vcs-Git: git://gitorious.org/dma-roam/pkg-debian.git +Vcs-Browser: http://gitorious.org/dma-roam/pkg-debian Package: dma Architecture: any diff -Nru dma-0.0.2010.06.17/debian/migrate/dma-migrate.c dma-0.0.2010.06.17/debian/migrate/dma-migrate.c --- dma-0.0.2010.06.17/debian/migrate/dma-migrate.c 2010-06-18 17:58:48.000000000 +0300 +++ dma-0.0.2010.06.17/debian/migrate/dma-migrate.c 2010-10-06 17:06:47.000000000 +0300 @@ -71,7 +71,7 @@ { const char *spooldir; int hflag, Vflag, errs, fd, res; - char ch; + int ch; DIR *d; struct dirent *e; struct stat sb; @@ -99,7 +99,9 @@ break; case '?': + default: usage(1); + /* NOTREACHED */ } if (Vflag) version();
signature.asc
Description: Digital signature
