On Sat, Aug 28, 2010 at 01:33:10PM +0200, Marc 'HE' Brockschmidt wrote: > Hi Roger, > > Roger Leigh <rle...@codelibre.net> writes: > > Please could you unblock schroot 1.4.10-2? > > 127 files changed, 6132 insertions(+), 6896 deletions(-) > > *cough* This is a bit much and far away from properly reviewable - even > if we filter out all autoconf crop and documentation updates. Are all of > these changes really needed?
Yes. If you look at the diffstat (below), you'll see that the majority of the changes are translation and doxygen template changes. The source changes are mainly confined to - additions and updates to the doxygen documentation - namespace support (sbuild-chroot-config.cc) - unifying chroot name and session name (a number of single line changes to most of the source files below) I have reviewed all the source changes myself, being the upstream as well as the Debian packager. As in, I've been through the diffs several times over line by line with each release. 1.4.11-1 should be as stable as 1.4.7-1 and it contains a good number of bugfixes (some RC). There was a long list of wishlist bugs I wanted to fix for squeeze in the BTS in addition to a number of actual bugs in the software of various severities. I've fixed all the outstanding bugs and added/updated several features in order to complete all the outstanding issues. This new release is the result of that, and it's what I'd like to be released with squeeze. This work was completed in the 1.4.8 release with the subsequent 4 releases over the past few weeks being confined to translation updates and a few small one liner bugfixes. (Note I just uploaded 1.4.11-1 to fix a single new issue). Regards, Roger % git diff --stat release/schroot-1.4.7..release/schroot-1.4.11 Makefile.am | 5 +- NEWS | 62 +- README | 25 +- TODO | 13 +- bin/dchroot-dsa/dchroot-dsa-chroot-config.cc | 16 +- bin/dchroot-dsa/dchroot-dsa-chroot-config.h | 12 +- bin/dchroot-dsa/dchroot-dsa-main.cc | 3 +- bin/dchroot-dsa/dchroot-dsa-main.h | 3 + bin/dchroot-dsa/dchroot-dsa-session.cc | 5 +- bin/dchroot-dsa/dchroot-dsa-session.h | 4 +- bin/dchroot/dchroot-chroot-config.cc | 16 +- bin/dchroot/dchroot-chroot-config.h | 12 +- bin/dchroot/dchroot-main.cc | 5 +- bin/dchroot/dchroot-main.h | 3 + bin/dchroot/dchroot-session-base.cc | 5 +- bin/dchroot/dchroot-session-base.h | 4 +- bin/dchroot/dchroot-session.cc | 11 +- bin/dchroot/dchroot-session.h | 12 +- bin/schroot-base/schroot-base-main.h | 7 + bin/schroot-base/schroot-base-option-action.h | 24 +- bin/schroot-base/schroot-base-options.h | 1 + bin/schroot-listmounts/schroot-listmounts-main.h | 3 + bin/schroot-mount/schroot-mount-main.h | 3 + bin/schroot-releaselock/schroot-releaselock-main.h | 3 + bin/schroot/schroot-main-base.cc | 103 +- bin/schroot/schroot-main-base.h | 11 +- bin/schroot/schroot-main.cc | 4 +- bin/schroot/schroot-main.h | 3 + bin/schroot/schroot-options-base.cc | 53 +- bin/schroot/schroot-options-base.h | 4 +- bin/schroot/schroot-options.cc | 7 +- configure.ac | 74 +- debian/.gitignore | 2 + debian/changelog | 66 + debian/control | 7 +- debian/rules | 46 +- doc/Makefile.am | 27 +- doc/sbuild.dox.in | 1412 ++++++++++---------- doc/schroot.dox.in | 1390 ++++++++++---------- etc/schroot.conf | 8 - etc/setup.d/10mount | 29 +- man/schroot.1.in | 85 +- man/schroot.conf.5.in | 4 +- po/LINGUAS | 1 + po/Makevars | 2 +- po/cs.po | 813 +++-------- po/da.po | 1377 +++++++++++++++++++ po/de.po | 429 +------ po/en.po | 396 +----- po/eu.po | 398 +----- po/fr.po | 515 ++------ po/it.po | 403 +----- po/pt.po | 401 +----- po/schroot.pot | 387 +----- po/sv.po | 402 +------ po/vi.po | 405 +----- po/zh_CN.po | 398 +----- sbuild/sbuild-auth-null.cc | 2 +- sbuild/sbuild-auth-null.h | 1 + sbuild/sbuild-auth-pam-conv-tty.h | 1 + sbuild/sbuild-auth-pam-conv.h | 3 +- sbuild/sbuild-auth-pam.cc | 6 +- sbuild/sbuild-auth-pam.h | 11 + sbuild/sbuild-auth.cc | 36 +- sbuild/sbuild-basic-keyfile.h | 2 +- sbuild/sbuild-chroot-block-device-base.cc | 14 +- sbuild/sbuild-chroot-block-device-base.h | 3 - sbuild/sbuild-chroot-block-device.cc | 20 +- sbuild/sbuild-chroot-block-device.h | 3 + sbuild/sbuild-chroot-btrfs-snapshot.cc | 33 +- sbuild/sbuild-chroot-config.cc | 393 +++++-- sbuild/sbuild-chroot-config.h | 185 ++- sbuild/sbuild-chroot-directory-base.cc | 12 +- sbuild/sbuild-chroot-directory.cc | 6 +- sbuild/sbuild-chroot-facet-mountable.cc | 21 +- sbuild/sbuild-chroot-facet-personality.cc | 4 +- sbuild/sbuild-chroot-facet-session-clonable.cc | 64 +- sbuild/sbuild-chroot-facet-session-clonable.h | 1 + sbuild/sbuild-chroot-facet-session.cc | 19 +- sbuild/sbuild-chroot-facet-source-clonable.cc | 32 +- sbuild/sbuild-chroot-facet-source-clonable.h | 2 +- sbuild/sbuild-chroot-facet-union.cc | 27 +- sbuild/sbuild-chroot-facet-union.h | 9 +- sbuild/sbuild-chroot-facet.h | 5 + sbuild/sbuild-chroot-file.cc | 25 +- sbuild/sbuild-chroot-loopback.cc | 8 +- sbuild/sbuild-chroot-lvm-snapshot.cc | 34 +- sbuild/sbuild-chroot.cc | 167 ++- sbuild/sbuild-chroot.h | 92 +- sbuild/sbuild-ctty.h | 2 + sbuild/sbuild-error.h | 2 +- sbuild/sbuild-keyfile.h | 3 + sbuild/sbuild-log.cc | 9 +- sbuild/sbuild-parse-value.h | 2 + sbuild/sbuild-run-parts.cc | 6 +- sbuild/sbuild-session.cc | 77 +- sbuild/sbuild-session.h | 60 +- sbuild/sbuild-types.h | 3 + sbuild/sbuild-util.cc | 18 +- sbuild/sbuild-util.h | 120 ++- test/sbuild-chroot-block-device.cc | 2 +- test/sbuild-chroot-btrfs-snapshot.cc | 2 +- test/sbuild-chroot-config.cc | 71 +- test/sbuild-chroot-directory.cc | 4 +- test/sbuild-chroot-file.cc | 2 +- test/sbuild-chroot-loopback.cc | 2 +- test/sbuild-chroot-lvm-snapshot.cc | 4 +- test/sbuild-chroot.cc | 2 +- test/test-sbuild-chroot.h | 10 +- 109 files changed, 4973 insertions(+), 6588 deletions(-) -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
