Package: release.debian.org
Severity: normal
Tags: trixie
Control: affects -1 + src:google-recaptcha
User: [email protected]
Usertags: pu

Hi,

[ Reason ]
Users have PHP deprecations due to missing nullable signatures for some 
functions.
This deprecation was not detected earlier, else it would already be into Debian 
as a patch.

[ Impact ]
Users have PHP deprecations in their logs and interfaces.

[ Tests ]
A new unit test was written to validate the patch and is pushed to unstable.
And it runs fine: 
https://debusine.debian.net/debian/developers/artifact/2426711/file/minimal-test-stdout

You can test with this simple test: php -n -r "require_once 
'/usr/share/php/ReCaptcha/autoload.php';\$recaptcha = new 
\ReCaptcha\ReCaptcha('xxxxxx');"
It says:
"Deprecated: ReCaptcha\ReCaptcha::__construct(): Implicitly marking parameter 
$requestMethod as nullable is deprecated, the explicit nullable type must be 
used instead in /usr/share/php/ReCaptcha/ReCaptcha.php on line 139"

The debdiff was tested in Debusine: 
https://debusine.debian.net/debian/developers/work-request/158108/
And is pending confirmation on this bug to be uploaded.

[ Risks ]
Not much risk thanks to the testing described above.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

Please allow me to upload google-recaptcha/1.3.0-2deb13u1 as per attached 
debdiff.
Salsa diff: 
https://salsa.debian.org/php-team/pear/google-recaptcha/-/compare/debian%2F1.3.0-2...debian%2Ftrixie?from_project_id=25519

--
William Desportes

Attachment: google-recaptcha_1.3.0-2deb13u1.debdiff
Description: Binary data

Reply via email to