Package: release.debian.org Severity: normal Tags: bookworm X-Debbugs-Cc: [email protected], Roland Rosenfeld <[email protected]>, Debian Perl Group <[email protected]>, [email protected] Control: affects -1 + src:libfile-tail-perl User: [email protected] Usertags: pu
Dear stable release managers, [ Reason ] There is a longstanding issue in File::Tail which under some conditions triggers warnings Use of uninitialized value in numeric eq (==) at /usr/share/perl5/File/Tail.pm line 391. This is long reported upstream at https://rt.cpan.org/Ticket/Display.html?id=109163 (with dormant upstream). [ Impact ] In some toolings annoying regular warnings about unitialized values in numeric comparison. [ Tests ] Manual test with a real-world example triggering the problem. [ Risks ] While upstream is dormant, the changes were for long already applied in Fedora for instance (not checked about others). [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in (old)stable [x] the issue is verified as fixed in unstable [ Changes ] Initialize inode to 0, as this should never happend and thus can be initialized to it, and then later get set while probing on the real inode. Regards, Salvatore
diff -Nru libfile-tail-perl-1.3/debian/changelog libfile-tail-perl-1.3/debian/changelog --- libfile-tail-perl-1.3/debian/changelog 2022-10-14 12:55:11.000000000 +0200 +++ libfile-tail-perl-1.3/debian/changelog 2025-06-03 08:51:10.000000000 +0200 @@ -1,3 +1,12 @@ +libfile-tail-perl (1.3-7+deb12u1) bookworm; urgency=medium + + * Team upload. + + [ Roland Rosenfeld ] + * Fix uninitialized variable issue (Closes: #1104900). + + -- Salvatore Bonaccorso <[email protected]> Tue, 03 Jun 2025 08:51:10 +0200 + libfile-tail-perl (1.3-7) unstable; urgency=medium * Update to Standards-Version 4.6.1 (no changes). diff -Nru libfile-tail-perl-1.3/debian/patches/30_init-objects.patch libfile-tail-perl-1.3/debian/patches/30_init-objects.patch --- libfile-tail-perl-1.3/debian/patches/30_init-objects.patch 1970-01-01 01:00:00.000000000 +0100 +++ libfile-tail-perl-1.3/debian/patches/30_init-objects.patch 2025-06-03 08:51:10.000000000 +0200 @@ -0,0 +1,33 @@ +From: Tom Callaway <[email protected]> +Date: Nov 18 2020 20:29:02 +0000 +Subject: fix uninitialized variable issue (bz1283764) +Origin: https://src.fedoraproject.org/rpms/perl-File-Tail/c/5892b1b7d2784a81debeb7cdf10e7b062533020e +Bug: https://rt.cpan.org/Ticket/Display.html?id=109163 +Bug-Debian: https://bugs.debian.org/1104900 +Bug-Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1283764 +Last-Update: 2025-05-09 + +--- a/Tail.pm.debug ++++ b/Tail.pm.debug +@@ -382,6 +382,9 @@ sub reset_pointers { + if (defined($oldhandle)) { + # If file has not been changed since last OK read do not do anything + $st=stat($newhandle); ++ # inode 0 should never happen, so this should be safe to init to. ++ $object->{'inode'}=0 unless defined($object->{'inode'}); ++ $object->{'curpos'}=0 unless defined($object->{'curpos'}); + # lastread uses fractional time, stat doesn't. This can cause false + # negatives. + # If the file was changed the same second as it was last read, +--- a/Tail.pm ++++ b/Tail.pm +@@ -378,6 +378,9 @@ sub reset_pointers { + if (defined($oldhandle)) { + # If file has not been changed since last OK read do not do anything + $st=stat($newhandle); ++ # inode 0 should never happen, so this should be safe to init to. ++ $object->{'inode'}=0 unless defined($object->{'inode'}); ++ $object->{'curpos'}=0 unless defined($object->{'curpos'}); + # lastread uses fractional time, stat doesn't. This can cause false + # negatives. + # If the file was changed the same second as it was last read, diff -Nru libfile-tail-perl-1.3/debian/patches/series libfile-tail-perl-1.3/debian/patches/series --- libfile-tail-perl-1.3/debian/patches/series 2022-10-14 12:55:11.000000000 +0200 +++ libfile-tail-perl-1.3/debian/patches/series 2025-06-03 08:51:10.000000000 +0200 @@ -1,2 +1,3 @@ 10_pod_fixup.patch 20_manpage_typo.patch +30_init-objects.patch
