Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: python-pycd...@packages.debian.org, sanv...@debian.org, 
z...@debian.org
Control: affects -1 + src:python-pycdlib

[ Reason ]
This fixes Bug #1002789, FTBFS unless /tmp is on tmpfs.

[ Impact ]
Anybody trying to build the package might unexpectedly find that
the package fails to build unexpectedly. Apparently this worked
in the buildds because they have /tmp on tmpfs, but this is not
part of the build-essential definition and also debian-installer
in bookworm does not setup /tmp as tmpfs by default.

[ Tests ]
I've checked that the build works again when /tmp is not in tmpfs.

[ Risks ]
Very low. Only the tests are affected, and we only skip them when we know
that they will fail.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
debian/rules checks that /tmp is in tmpfs and skips the tests if not.
This is the same fix currently in unstable.

[ Other info ]
I'm not uploading yet. This is currently a NMU, but I would much prefer
it not to be. If Thomas wants to remove the non-maintainer line from
the changelog and become the real uploader, he's more than welcome
to do so, and I would prefer it that way.
diff -Nru python-pycdlib-1.12.0+ds1/debian/changelog 
python-pycdlib-1.12.0+ds1/debian/changelog
--- python-pycdlib-1.12.0+ds1/debian/changelog  2022-10-25 15:46:06.000000000 
+0200
+++ python-pycdlib-1.12.0+ds1/debian/changelog  2024-12-30 18:55:00.000000000 
+0100
@@ -1,3 +1,11 @@
+python-pycdlib (1.12.0+ds1-4+deb12u1) bookworm; urgency=medium
+
+  * Non-maintainer upload.
+  * Run tests only if /tmp is in tmpfs, because otherwise they are
+    known to fail. (Closes: #1002789).
+
+ -- Santiago Vila <sanv...@debian.org>  Mon, 30 Dec 2024 18:55:00 +0100
+
 python-pycdlib (1.12.0+ds1-4) unstable; urgency=medium
 
   * Add fix-getargspec-removed-from-py3.11.patch (Closes: #1030535).
diff -Nru python-pycdlib-1.12.0+ds1/debian/rules 
python-pycdlib-1.12.0+ds1/debian/rules
--- python-pycdlib-1.12.0+ds1/debian/rules      2022-10-25 15:46:06.000000000 
+0200
+++ python-pycdlib-1.12.0+ds1/debian/rules      2024-12-30 18:53:19.000000000 
+0100
@@ -3,6 +3,8 @@
 UPSTREAM_GIT := http://github.com/clalancette/pycdlib
 include /usr/share/openstack-pkg-tools/pkgos.make
 
+TMP_IS_TMPFS := $(shell egrep -q "^tmpfs[[:space:]]+/tmp[[:space:]]" 
/proc/mounts && echo true || echo false)
+
 %:
        dh $@ --with python3
 
@@ -18,10 +20,12 @@
        pkgos-dh_auto_install --no-py2 --in-tmp
 
 ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
+ifeq ($(TMP_IS_TMPFS),true)
        set -e ; set -x ; for pyvers in $(PYTHON3S); do \
                PATH=$$PATH:$(CURDIR)/debian/tmp/usr/bin 
PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages python$$pyvers -m 
pytest tests ; \
        done
 endif
+endif
 
 override_dh_python3:
        dh_python3 --shebang=/usr/bin/python3

Reply via email to