Your message dated Sat, 31 Aug 2024 12:30:55 +0100
with message-id
<27c418b1a49ffc566f1b9635359e59f6a742be26.ca...@adam-barratt.org.uk>
and subject line Closing bugs for 11.11
has caused the Debian Bug report #1007884,
regarding bullseye-pu: package glewlwyd/2.5.2-2+deb11u3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1007884: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007884
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: important
Tags: bullseye
User: release.debian....@packages.debian.org
Usertags: pu
(Please provide enough information to help the release team
to judge the request efficiently. E.g. by filling in the
sections below.)
[ Reason ]
Possible buffer overflow on signature verification during webauthn assertion
[ Impact ]
Possibility of denial of service
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
Check the length of the signature before verifying it
[ Other info ]
CVE ID request pending
Description: Fix buffer overflow
Author: Nicolas Mora <babelou...@debian.org>
Forwarded: not-needed
--- a/src/scheme/webauthn.c
+++ b/src/scheme/webauthn.c
@@ -2336,12 +2336,24 @@
break;
}
- if (!o_base64url_decode((const unsigned char
*)json_string_value(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")),
json_string_length(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")), sig, &sig_len)) {
- y_log_message(Y_LOG_LEVEL_DEBUG, "check_assertion - Error
o_base64url_decode signature");
+ if (!o_base64_decode((const unsigned char
*)json_string_value(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")),
json_string_length(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")), NULL, &sig_len)) {
+ y_log_message(Y_LOG_LEVEL_DEBUG, "check_assertion - Invalid signature
format");
ret = G_ERROR_PARAM;
break;
}
+ if (sig_len > 128) {
+ y_log_message(Y_LOG_LEVEL_DEBUG, "check_assertion - Invalid
signature");
+ ret = G_ERROR_PARAM;
+ break;
+ }
+
+ if (!o_base64_decode((const unsigned char
*)json_string_value(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")),
json_string_length(json_object_get(json_object_get(json_object_get(j_scheme_data,
"credential"), "response"), "signature")), sig, &sig_len)) {
+ y_log_message(Y_LOG_LEVEL_DEBUG, "check_assertion - Error
o_base64_decode signature");
+ ret = G_ERROR;
+ break;
+ }
+
memcpy(data_signed, auth_data, auth_data_len);
memcpy(data_signed+auth_data_len, cdata_hash, cdata_hash_len);
--- End Message ---
--- Begin Message ---
Package: release.debian.org
Version: 11.11
Hi,
Each of these bugs relates to an update including in today's final
bullseye 11.11 point release.
Regards,
Adam
--- End Message ---
