Control: tag -1 confirmed
On Sat, Dec 04, 2021 at 12:51:31AM +0530, Nilesh Patra wrote:
> On 3 December 2021 9:41:48 pm IST, Julien Cristau <jcris...@debian.org> wrote:
> >On Tue, Sep 07, 2021 at 12:27:05AM +0530, Nilesh Patra wrote:
> >> diff -Nru segemehl-0.3.4/debian/patches/arm64.patch
> >> segemehl-0.3.4/debian/patches/arm64.patch
> >> --- segemehl-0.3.4/debian/patches/arm64.patch 1970-01-01
> >> 05:30:00.000000000 +0530
> >> +++ segemehl-0.3.4/debian/patches/arm64.patch 2021-09-06
> >> 23:43:50.000000000 +0530
> >> @@ -0,0 +1,75 @@
> >> +Description: Change the signed-ness for several chars to fix segfault
> >> +Author: Nilesh Patra <nil...@debian.org>
> >> +Last-Update: 2021-08-24
> >> +--- a/libs/biofiles.c
> >> ++++ b/libs/biofiles.c
> >> +@@ -1916,7 +1916,7 @@
> >> + Uint max, Uint *minlen, Uint *maxlen, unsigned char *minq, unsigned
> >> char *maxq)
> >> + {
> >> +
> >> +- char ch;
> >> ++ signed char ch;
> >> + char idchar=0;
> >> + int ret=0;
> >> + off_t curseqoffset, lastindexoffset=0;
> >
> >Shouldn't `ch` be an `int` instead, to match the return value of getc,
> >and type of EOF?
> >
> >Anyway, I guess this is fine if it works...
>
> Should I upload this to p-u?
If it's still relevant, yes please (sorry for the delay). If not please
close the request.
Thanks,
--
Jonathan Wiltshire j...@debian.org
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1
