Control: tags -1 -moreinfo +confirmed
On Wed, 2023-10-18 at 11:31 -0400, Jay Berkenbilt wrote:
> On Tue, Oct 17, 2023, at 12:15 PM, Adam D. Barratt wrote:
> >
[...]
> > Close, but a few rough edges. :-)
> >
>
> Ah, thanks for helping me get past my brain rot. When I used to
> maintain several packages, including tiff and icu, which had lots of
> security updates, I was much more familiar with this. It's funny how
> we can forget something so thoroughly that we can forget we knew it
> at one time. The doc reference was perfect and jogged my memory.
>
Great. :)
A small style thought:
+ this->val += char(this->char_code % 256);
+ this->state = st_in_string;
+- return;
++ if (!handled) {
++ inString(ch);
++ }
You've lost the explicit "return" there. So far as I can see there's no
practical impact, I just wasn't sure if you wanted it stylistically.
Either way, please go ahead.
Regards,
Adam
