Your message dated Sat, 22 Jul 2023 13:19:40 +0000
with message-id <e1qncwk-005rmk...@coccia.debian.org>
and subject line Released with 12.1
has caused the Debian Bug report #1036849,
regarding bookworm-pu: package gnome-software/43.5-1~deb12u1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1036849: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036849
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: gnome-softw...@packages.debian.org
Control: affects -1 + src:gnome-software
GNOME upstream has done a stable point release of gnome-software. This
doesn't seem urgent enough to want to break the freeze for, but it would
be good to get it in 12.1.
[ Reason ]
User request on #1036312; upstream stable release fixing memory leaks
[ Impact ]
If not fixed, presumably gnome-software will gradually leak memory.
I've asked the reporter of #1036312 for further context.
The bug reporter describes these as security fixes, but I don't understand
the basis for saying this.
[ Tests ]
Manually tested on my laptop (mixed testing+unstable+experimental),
seems to be able to upgrade packages successfully. I'll test it further
on a more pure bookworm system.
[ Risks ]
Low risk, the changes are narrowly-targeted and look obviously correct.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in bookworm
[ ] the issue is verified as fixed in unstable
[ Changes ]
New upstream release with memory leak fixes and no other changes.
[ Other info ]
I have not uploaded to unstable due to the full freeze, and I can't
upload to experimental because GNOME 44 is already there.
May I upload this to unstable as 43.5-1 to get it some more testing,
on the understanding that if there is an unforeseen urgent change to
gnome-software, these fixes can be included with it? If I do that,
presumably the upload to bookworm would become 43.5-1~deb12u1.
diff --git a/NEWS b/NEWS
index 1c3f395b5..535bae910 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,10 @@
+Version 43.5
+~~~~~~~~~~~~
+Released: 2023-03-03
+
+This is a stable release with the following change:
+ * Fix few memory leaks
+
Version 43.4
~~~~~~~~~~~~
Released: 2023-02-10
diff --git a/data/metainfo/org.gnome.Software.metainfo.xml.in b/data/metainfo/org.gnome.Software.metainfo.xml.in
index 27b65fca0..a43e442d3 100644
--- a/data/metainfo/org.gnome.Software.metainfo.xml.in
+++ b/data/metainfo/org.gnome.Software.metainfo.xml.in
@@ -66,6 +66,14 @@
Validate with `appstreamcli validate *.metainfo.xml`
-->
<releases>
+ <release date="2023-03-03" version="43.5" type="stable">
+ <description>
+ <p>This is a stable release with the following change:</p>
+ <ul>
+ <li>Fix few memory leaks</li>
+ </ul>
+ </description>
+ </release>
<release date="2023-02-10" version="43.4" type="stable">
<description>
<p>This is a stable release with the following changes:</p>
diff --git a/debian/changelog b/debian/changelog
index a7a4411c4..21adfbac3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+gnome-software (43.5-0+deb12u1) UNRELEASED; urgency=medium
+
+ * d/gbp.conf: Use upstream/43.x branch to import new upstream versions
+ * d/watch: Only watch for versions 43.x
+ * New upstream release 43.5
+ - Fix some memory leaks (Closes: #1036312)
+ * Refresh patch series (no functional changes)
+
+ -- Simon McVittie <s...@debian.org> Sat, 27 May 2023 15:26:56 +0100
+
gnome-software (43.4-1) unstable; urgency=medium
* New upstream release
diff --git a/debian/gbp.conf b/debian/gbp.conf
index 50a9f77f2..4a341ca18 100644
--- a/debian/gbp.conf
+++ b/debian/gbp.conf
@@ -1,7 +1,7 @@
[DEFAULT]
pristine-tar = True
debian-branch = debian/bookworm
-upstream-branch = upstream/latest
+upstream-branch = upstream/43.x
[buildpackage]
sign-tags = True
diff --git a/debian/patches/01_details-Use-custom-icon-for-verified-developers.patch b/debian/patches/01_details-Use-custom-icon-for-verified-developers.patch
index 93660036e..5f79360e2 100644
--- a/debian/patches/01_details-Use-custom-icon-for-verified-developers.patch
+++ b/debian/patches/01_details-Use-custom-icon-for-verified-developers.patch
@@ -29,7 +29,7 @@ index 0000000..57c0f11
+</svg>
\ No newline at end of file
diff --git a/src/gnome-software.gresource.xml b/src/gnome-software.gresource.xml
-index 941dd40..2d1f2ff 100644
+index 4efe369..9f897a5 100644
--- a/src/gnome-software.gresource.xml
+++ b/src/gnome-software.gresource.xml
@@ -54,6 +54,7 @@
@@ -41,7 +41,7 @@ index 941dd40..2d1f2ff 100644
<file preprocess="xml-stripblanks" alias="icons/scalable/apps/system-component-addon.svg">../data/icons/system-component-addon.svg</file>
<file preprocess="xml-stripblanks" alias="icons/scalable/apps/system-component-application.svg">../data/icons/system-component-application.svg</file>
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
-index 8b0e88b..4c120ef 100644
+index d3fad10..37c657b 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -173,7 +173,7 @@
diff --git a/debian/watch b/debian/watch
index 64675b41f..94c24ddb9 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,4 +1,4 @@
version=4
opts="searchmode=plain, uversionmangle=s/\.(alpha|beta|rc)/~$1/, downloadurlmangle=s|cache.json||" \
https://download.gnome.org/sources/@PACKAGE@/cache.json \
- [\d.]+/@PACKAGE@-([\d.]+)@ARCHIVE_EXT@
+ 43/@PACKAGE@-([\d.]+)@ARCHIVE_EXT@
diff --git a/lib/gs-plugin-job-list-apps.c b/lib/gs-plugin-job-list-apps.c
index a556387e5..56a4e14be 100644
--- a/lib/gs-plugin-job-list-apps.c
+++ b/lib/gs-plugin-job-list-apps.c
@@ -84,6 +84,7 @@ gs_plugin_job_list_apps_dispose (GObject *object)
g_assert (self->n_pending_ops == 0);
g_clear_object (&self->result_list);
+ g_clear_object (&self->query);
G_OBJECT_CLASS (gs_plugin_job_list_apps_parent_class)->dispose (object);
}
diff --git a/lib/gs-plugin-job-manage-repository.c b/lib/gs-plugin-job-manage-repository.c
index 7ee444449..2b8ee668b 100644
--- a/lib/gs-plugin-job-manage-repository.c
+++ b/lib/gs-plugin-job-manage-repository.c
@@ -63,6 +63,8 @@ gs_plugin_job_manage_repository_dispose (GObject *object)
g_assert (self->saved_error == NULL);
g_assert (self->n_pending_ops == 0);
+ g_clear_object (&self->repository);
+
G_OBJECT_CLASS (gs_plugin_job_manage_repository_parent_class)->dispose (object);
}
diff --git a/meson.build b/meson.build
index 77e3eab51..20400eaa3 100644
--- a/meson.build
+++ b/meson.build
@@ -1,5 +1,5 @@
project('gnome-software', 'c',
- version : '43.4',
+ version : '43.5',
license : 'GPL-2.0+',
default_options : ['warning_level=1', 'c_std=c11'],
meson_version : '>=0.58.0'
--- End Message ---
--- Begin Message ---
Version: 12.1
The upload requested in this bug has been released as part of 12.1.
--- End Message ---
