On Mon, Jun 14, 2021 at 9:45 AM Sebastian Ramacher wrote: > > xscreensaver already migrated.
Thanks for taking care of the migration! > > Question: > > The trivial addition of a missing " || true" in debian/rules* would fix > > building on kfreebsd/hurd. Could that be considered? > > I would prefer changes not relevant for bullseye to be deferred for > bookworm. This makes it easier to review unblock requests. > > In any case, the change would be wrong. It would hide legitimate build > failures on other architectures. If this part of the build is not > supposed to run on kfreebsd-*, do not run it on kfreebsd. It is not that bad: We only pull in the systemd-dev dependency on Linux, through debian/control. The upstream build only generates the systemd tool if the dev library was pulled in. The || true in question is only closing the "if a built systemd tool exists, install it" clause. A build failure on any architecture would fail in the build proper, before this install step. If we should add an arch-specific clause in debian/rules, it would be two places to maintain. But in case, what is the recommended way to do it? dpkg-architecture matching? Regards, Tormod
