Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package simgrid

[ Reason ]
simgrid is marked for removal for April 28., because of #858498 that is
Serious; this upload fixes that bug.

[ ImpactThe ]
 bug is that the so link of a library can be dead because of a missing
dependency between the simgrid packages.
This upload removes the solink because the library in question is the JNI
bindings, so no user will ever want to link native code against this java-
specific library.

[ Tests ]
Simgrid comes with a rather large test suite in the build tree. Lintian was
also ran.

[ Risks ]
The code is completely trivial. The change is basically to remove the solink
from the debian/??.install, and rm it before installing in d/rules.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
(Anything else the release team should know: I'm thankful to your work and the
time you dedicate to the project :)

unblock simgrid/3.25+dfsg-5

-- 
If you do not expect the unexpected, you will not find it.   -- Heraclitus      
                                    
diff -Nru simgrid-3.25+dfsg/debian/changelog simgrid-3.25+dfsg/debian/changelog
--- simgrid-3.25+dfsg/debian/changelog  2020-06-14 15:25:31.000000000 +0200
+++ simgrid-3.25+dfsg/debian/changelog  2021-04-13 09:59:59.000000000 +0200
@@ -1,3 +1,15 @@
+simgrid (3.25+dfsg-5) unstable; urgency=medium
+
+  * Don't install the libsimgrid-java.so symlink as nobody will ever
+    want to compile any native code against our JNI bindings. 
+    
+    This saves a dependency from libsimgrid-dev onto libsimgrid-java
+    that would be needed to ensure that this link is never dead, but
+    this would make the whole java world as a dependency of simgrid
+    development (Closes: #858498).
+
+ -- Martin Quinson <mquin...@debian.org>  Tue, 13 Apr 2021 09:59:59 +0200
+
 simgrid (3.25+dfsg-4) unstable; urgency=medium
 
   * Don't build-depend on libunwind that is only needed by the
diff -Nru simgrid-3.25+dfsg/debian/libsimgrid-dev.install 
simgrid-3.25+dfsg/debian/libsimgrid-dev.install
--- simgrid-3.25+dfsg/debian/libsimgrid-dev.install     2020-06-14 
15:25:31.000000000 +0200
+++ simgrid-3.25+dfsg/debian/libsimgrid-dev.install     2021-04-13 
09:59:59.000000000 +0200
@@ -22,7 +22,6 @@
 usr/share/man/man1/simgrid_update_xml.1
 
 usr/lib/pkgconfig/simgrid.pc
-usr/lib/libsimgrid-java.so
 usr/lib/libsimgrid.so
 
 usr/bin/tesh
diff -Nru simgrid-3.25+dfsg/debian/rules simgrid-3.25+dfsg/debian/rules
--- simgrid-3.25+dfsg/debian/rules      2020-06-14 15:25:31.000000000 +0200
+++ simgrid-3.25+dfsg/debian/rules      2021-04-13 09:59:59.000000000 +0200
@@ -56,14 +56,23 @@
 # Make install and prepare package building
 override_dh_auto_install:
        dh_auto_install
+       
        # Manually install the python module, since upstream fails to do so
        mkdir -p debian/tmp/usr/lib/python3/dist-packages
        cp obj-*/lib/simgrid.cpython*.so 
debian/tmp/usr/lib/python3/dist-packages
        chrpath -d debian/tmp/usr/lib/python3/dist-packages/simgrid.cpython*.so
+       
        # Fix chrpath of binaries
        chrpath -d debian/tmp/usr/bin/graphicator
        chrpath -d debian/tmp/usr/lib/simgrid/smpimain
        mv debian/tmp/usr/bin/graphicator debian/tmp/usr/bin/simgrid-graphicator
+       
+       # Remove the so link of the JNI library, as is does not fit in
+       # libsimgrid-dev without inducing a dependency from simgrid-dev to the
+       # whole java world, and this library is of no use in the
+       # native world, only useful in Java (that does not need the so link)
+       rm debian/tmp/usr/lib/libsimgrid-java.so
+       
        # move doc to correct place
 #      mkdir -p debian/tmp/usr/share/doc/simgrid
 #      mv debian/tmp/usr/doc/simgrid/* debian/tmp/usr/share/doc/simgrid/

Attachment: signature.asc
Description: PGP signature

Reply via email to