Control: tags -1 - moreinfo
On Mon, 2019-08-26 at 23:37 +0200, Hans-Christoph Steiner wrote:
> Adam D. Barratt:
[...]
> > On Mon, 2019-08-26 at 14:54 +0200, Hans-Christoph Steiner wrote:
[...]
> They are mostly from compatibility bugs discovered since the final
> buster freeze. Some were fixed before the freeze, but we spent a lot
> of time testing this package on buster, so we wanted until the tests
> were complete before requesting an unblock. This release is meant to
> be an LTS for fdroidserver, and we'll be working to get it into other
> distros too.
[...]
> > > What
> > > makes the debdiff long is the cruft that were removed upstream in
> > > the
> > > source tarball due to a cleanup (see diffstat).
> >
> > Are you really saying that what looks from the diff like dropping
> > all localisation support is cruft cleanup? I feel like I may be
> > missing something.
>
> The localization was not removed. The localization user-editable .po
> files were removed while the .mo files are still there, which are
> what are actually used to display the strings.. The .mo files can be
> converted back to .po files as needed using msgunfmt, so they are
> also "source".
That seems an unusual approach, in that I would instead have expected
you to ship the .po files and generate the .mo at package build time,
but I guess it works.
> > In any case, cleaning up cruft by removing 60K lines of files from
> > your source package is generally not the sort of thing that would
> > be expected in a stable update.
>
> Yeah, this is annoying for sure. This cleanup was not triggered by
> me, it came from creating the source tarball on buster, while v1.1.1
> was created on stretch. The update to the standard Python tools that
> generate source tarballs seems to be the cause. I only noticed this
> after the release was done and uploaded. Sorry.
Well, you said above that you (as in upstream) intentionally removed
the PO files, so it seems you at least partly triggered it.
> > > The next largest block of changes is fixes to the test suite to
> > > work
> > > properly on Debian/buster.
> > > The remaining changes are compatibility fixes related to:
> > >
> > > 929905: incompatible with upstream's data repository
[...]
> > Please provide a diff that only includes the non-"cruft" changes,
> > so
> > there's a chance of us knowing what you're actually changing.
>
> I attached an excerpted debdiff without the aforementioned source
> tarball removals.
Thanks for that.
As a note, it may have been worth describing at least the "no-keep-git-
mirror-archive" and "archive-older" changes in your changelog(s). It's
possible they relate to one of the changes that you /have/ described,
but I'm honestly not sure.
+ help=_("If a git mirror gets to big, allow the archive
to be deleted"))
That first "to" should be "too" - i.e. "gets too big".
Regards,
Adam
