Control: tag -1 moreinfo

On Wed, Jul 10, 2019 at 09:55:20AM +0200, Thomas Goirand wrote:
> > Please allow me to fixup OVS's missing python3-six dependency, and add
> > support for fixing the MTU of OVS devices. The attached patch is quite
> > minimalistic. This also adds a bit of doc on how to set things up in
> > /etc/network/interfaces.

Not (yet) commenting on suitability, but there are some obvious issues with
the diff at a first glance:

> diff -Nru openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/changelog 
> openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/changelog
> --- openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/changelog 
> 2019-04-14 00:25:19.000000000 +0200
> +++ openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/changelog 
> 2019-06-24 08:53:33.000000000 +0200
> @@ -1,3 +1,11 @@
> +openvswitch (2.10.0+2018.08.28+git.8ca7c82b7d+ds1-12+deb10u1) buster; 
> urgency=medium
> +
> +  * Some fixups in debian/ifupdown.sh to allow setting-up the MTU.
> +  * Document how to do Bond + Bridge + VLAN + MTU.
> +  * Correct dependency on python3-six instead of python-six (Closes: 
> #931104).
> +
> + -- Thomas Goirand <z...@debian.org>  Mon, 24 Jun 2019 08:53:33 +0200
> +
>  openvswitch (2.10.0+2018.08.28+git.8ca7c82b7d+ds1-12) unstable; 
> urgency=medium
>  
>    * Add --may-exist in debian/ifupdown.sh as per upstream commit. Without it,
> @@ -7,6 +15,18 @@
>  
>  openvswitch (2.10.0+2018.08.28+git.8ca7c82b7d+ds1-11) unstable; 
> urgency=medium
>  
> +  * Removes network.service from openvswitch-switch.service to avoid a
> +    dependency loop in systemd, leading to removal of networking.service.
> +    Also use "ip link set DEVNAME up" instead of ifconfig, and runtime
> +    depend on iproute2.
> +    Thanks to Benjamin Drung for the bug report (Closes: #924562) and to
> +    Jonathan Dupart for the patch as a merge request in Salsa.
> +
> + -- Thomas Goirand <z...@debian.org>  Sun, 31 Mar 2019 00:50:26 +0100
> +>>>>>>> debian/stein
> +
> +openvswitch (2.10.0+2018.08.28+git.8ca7c82b7d+ds1-11) unstable; 
> urgency=medium
> +
>    * Removes network.service from openvswitch-switch.service to avoid a
>      dependency loop in systemd, leading to removal of networking.service.
>      Also use "ip link set DEVNAME up" instead of ifconfig, and runtime

Seem to be some merge artefacts here, including possibly an entire
duplicate entry?

-- 
Jonathan Wiltshire                                      j...@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Reply via email to