Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Please unblock package lprng
Lprng didn't run with buster dpkg because start-stop-daemon --stop got
more careful about ownership of pid files. It also didn't really work
with systemd because systemctl start lprng failed if lpd was already
running.
Uploaded to unstable just now so probably not dinstalled.
unblock lprng/3.8.B-2.2
diff --git a/debian/changelog b/debian/changelog
index 9849a12..2854c8e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+lprng (3.8.B-2.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Specify executable and user to stop-start-daemon; closes security
+ issue and fixes starting with buster dpkg, Closes: #928040
+ * Use --oknodo on start so that systemd doesn't fail if lprng is already
+ running, Closes: #908770
+
+ -- Sam Hartman <hartm...@debian.org> Wed, 22 May 2019 09:18:03 -0400
+
lprng (3.8.B-2.1) unstable; urgency=medium
* Non-maintainer upload.
diff --git a/debian/lprng.init.in b/debian/lprng.init.in
index b4df6b7..97edabd 100644
--- a/debian/lprng.init.in
+++ b/debian/lprng.init.in
@@ -97,7 +97,7 @@ case "$1" in
[ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" lpd
initialise
if start-stop-daemon --start --quiet --pidfile "${PIDFILE}" \
- --exec $DAEMON ; then
+ --oknodo --exec $DAEMON ; then
[ "$VERBOSE" != no ] && log_end_msg 0
else
[ "$VERBOSE" != no ] && log_end_msg 1
@@ -106,7 +106,8 @@ case "$1" in
;;
stop)
[ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" lpd
- if start-stop-daemon --stop --oknodo --quiet --pidfile "${PIDFILE}" ;
then
+ if start-stop-daemon --stop --oknodo --quiet --pidfile "${PIDFILE}" \
+ --exec $DAEMON --user daemon ; then
cleanup
[ "$VERBOSE" != no ] && log_end_msg 0
else
@@ -129,7 +130,8 @@ case "$1" in
;;
restart|force-reload)
[ "$VERBOSE" != no ] && log_daemon_msg "Restarting $DESC" lpd
- start-stop-daemon --stop --quiet --pidfile "${PIDFILE}"
+ start-stop-daemon --stop --quiet --pidfile "${PIDFILE}" \
+ --exec $DAEMON --user daemon
sleep 1
initialise
start-stop-daemon --start --quiet --pidfile "${PIDFILE}" \
-- System Information:
Debian Release: buster/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing'), (500, 'stable'), (200,
'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
