Hi Paul, and thanks for CCing me! On Sat, Mar 30, 2019 at 12:39:45PM +0100, Paul Gevers wrote: > Although we understand that the FTBFS issue in you package was caused by > an new version of your build dependency, which had an upload very much > not in line with the transition freeze at the time, we will not unblock > your package. The changes are just too large in this stage of releasing > buster. It would have helped your case if the work on packaging a newer > version of qgis would have started earlier, such that the updates in > buster would have been smaller.
First of all, sorry for breaking qgis. Sip 4.19.14 was a minor release and I did not expect it to break anything. And I learned about this breakage only now. Looks like the failure was caused by this upstream commit [1] which added SIP_OVERRIDE macro (aka override keyword) to the generated C++ methods. Adding override keyword did not change any ABI, so it should be safe to revert the second hunk of that commit. For packages which complied fine nothing will change, for qgis (and maybe some other packages?) the build failure will be fixed. Paul, will you unblock sip4 with this diff [2]? I will make sure it fixes qgis before uploading it. [1]: https://riverbankcomputing.com/hg/sip/rev/3ccc5b6f9e1f [2]: https://salsa.debian.org/python-team/modules/sip4/commit/16ac676e0701720d -- Dmitry Shachnev
signature.asc
Description: PGP signature
