Your message dated Thu, 21 Mar 2019 17:57:00 +0000 with message-id <ef48d4b6-2130-6035-230f-e0314f0c0...@thykier.net> and subject line Re: Bug#925245: unblock: gtk-vnc/0.9.0-1.1 has caused the Debian Bug report #925245, regarding unblock: gtk-vnc/0.9.0-1.1 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 925245: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925245 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock Please unblock package gtk-vnc gtk-vnc 0.9.0-1.1 fixes RC bug #909417, an FTBFS (no other changes). debdiff against 0.9.0-1: diff -Nru gtk-vnc-0.9.0/debian/changelog gtk-vnc-0.9.0/debian/changelog --- gtk-vnc-0.9.0/debian/changelog 2018-08-30 18:17:21.000000000 +0200 +++ gtk-vnc-0.9.0/debian/changelog 2019-03-21 09:24:41.000000000 +0100 @@ -1,3 +1,12 @@ +gtk-vnc (0.9.0-1.1) unstable; urgency=high + + * Non-maintainer upload. + * fix-unit-test-race.diff: New patch, fixes a race condition in unit tests + which would cause FTBFS, especially on builds with only a single CPU. + (Closes: #909417) + + -- Steinar H. Gunderson <se...@debian.org> Thu, 21 Mar 2019 09:24:41 +0100 + gtk-vnc (0.9.0-1) unstable; urgency=medium * [ffcc52b] New upstream version 0.9.0 diff -Nru gtk-vnc-0.9.0/debian/patches/fix-unit-test-race.diff gtk-vnc-0.9.0/debian/patches/fix-unit-test-race.diff --- gtk-vnc-0.9.0/debian/patches/fix-unit-test-race.diff 1970-01-01 01:00:00.000000000 +0100 +++ gtk-vnc-0.9.0/debian/patches/fix-unit-test-race.diff 2019-03-21 09:24:37.000000000 +0100 @@ -0,0 +1,71 @@ +Index: gtk-vnc-0.9.0/src/vncconnectiontest.c +=================================================================== +--- gtk-vnc-0.9.0.orig/src/vncconnectiontest.c ++++ gtk-vnc-0.9.0/src/vncconnectiontest.c +@@ -56,12 +56,23 @@ static void test_send_u8(GOutputStream * + g_assert(g_output_stream_write_all(os, &v, 1, NULL, NULL, NULL)); + } + ++static void send_u8(GOutputStream *os, guint8 v) ++{ ++ g_output_stream_write_all(os, &v, 1, NULL, NULL, NULL); ++} ++ + static void test_send_u16(GOutputStream *os, guint16 v) + { + v = GUINT16_TO_BE(v); + g_assert(g_output_stream_write_all(os, &v, 2, NULL, NULL, NULL)); + } + ++static void send_u16(GOutputStream *os, guint16 v) ++{ ++ v = GUINT16_TO_BE(v); ++ g_output_stream_write_all(os, &v, 2, NULL, NULL, NULL); ++} ++ + static void test_send_u32(GOutputStream *os, guint32 v) + { + v = GUINT32_TO_BE(v); +@@ -429,18 +440,18 @@ static void test_unexpected_cmap_server( + test_recv_u16(is, 100); + test_recv_u16(is, 100); + +- /* set color map */ ++ /* set color map -- after this, the client may close the connection at any time */ + test_send_u8(os, 1); + /* pad */ +- test_send_u8(os, 0); ++ send_u8(os, 0); + /* first color, ncolors */ +- test_send_u16(os, 0); +- test_send_u16(os, 1); ++ send_u16(os, 0); ++ send_u16(os, 1); + + /* r,g,b */ +- test_send_u16(os, 128); +- test_send_u16(os, 128); +- test_send_u16(os, 128); ++ send_u16(os, 128); ++ send_u16(os, 128); ++ send_u16(os, 128); + } + + +@@ -505,11 +516,13 @@ static void test_overflow_cmap_server(GI + test_send_u16(os, 65535); + test_send_u16(os, 2); + ++ /* after this, the client may close the connection at any time */ ++ + /* r,g,b */ + for (int i = 0 ; i < 2; i++) { +- test_send_u16(os, i); +- test_send_u16(os, i); +- test_send_u16(os, i); ++ send_u16(os, i); ++ send_u16(os, i); ++ send_u16(os, i); + } + } + diff -Nru gtk-vnc-0.9.0/debian/patches/series gtk-vnc-0.9.0/debian/patches/series --- gtk-vnc-0.9.0/debian/patches/series 2018-08-30 18:17:17.000000000 +0200 +++ gtk-vnc-0.9.0/debian/patches/series 2019-03-21 09:24:37.000000000 +0100 @@ -1,3 +1,4 @@ Remove-GNUmakefile-links.patch Add-I-m4-to-Makefile.am.patch gvnc-1.0.pc.in-Use-GLIB_REQUIRED.patch +fix-unit-test-race.diff unblock gtk-vnc/0.9.0-1.1 -- System Information: Debian Release: buster/sid APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.18.11 (SMP w/40 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8), LANGUAGE=en_NO:en_US:en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---Steinar H. Gunderson: > Package: release.debian.org > Severity: normal > User: release.debian....@packages.debian.org > Usertags: unblock > > Please unblock package gtk-vnc > > gtk-vnc 0.9.0-1.1 fixes RC bug #909417, an FTBFS (no other changes). > debdiff against 0.9.0-1: > > [...] > > unblock gtk-vnc/0.9.0-1.1 > > [...] > Unblocked, thanks. ~Niels
--- End Message ---
