On Sat, 2018-03-24 at 09:57 +0000, Niels Thykier wrote:
> I have written a branch that replaces most of our ad-hoc log
> framework
> with the standard python3 logging framework.  The branch is available
> from:
> 
> https://anonscm.debian.org/cgit/users/nthykier/britney.git/log/?h=rew
> rite-logging

One comment I would make, having recently added logging to
debrelease.*, is that the preferred style for supplying data for log
entries is the printf / varargs style, rather than the traditional
Python version - i.e.:

logger.info("Something %s; something else %s", foo, bar)

rather than

logger.info("Something %s; something else %s" % (foo, bar))

Adam

Reply via email to