Hi, Samuel Thibault <[email protected]> (2017-12-17): > Several blind users have reported that the Debian Installer speech > synthesis was not working on their computer, thus making it unusable > for them. It happens that this is due to odd numbering of sound cards > by ALSA on those computers. We have fixed this in buster, it has been > successfully tested on the reported systems, so I propose to include the > fix in Stretch too, I have attached the diff. I'm also Cc-ing Kibi for > his opinion on this.
Yeah, I've noticed the fix for buster, and I'm fine with fixing this for stretch as well, but see below. > +espeakup (1:0.80-5+deb9u1) stretch; urgency=medium > + > + * debian/espeakup-udeb.start: Fix case where card 0 does not have an id or > + where cards have non-contiguous indexes. > + * debian/espeakup-udeb.finish-install: Use card id in installed system > + to avoid issues with card detection ordering. No mention of “-V en” addition. > - echo 0 > /var/run/espeakup.card > - /usr/bin/espeakup > /var/log/espeakup.log 2>&1 > + echo $(strip $IDS) > /var/run/espeakup.card > + /usr/bin/espeakup -V en > /var/log/espeakup.log 2>&1 but it gets added here… > - ALSA_CARD=$(cat > /sys/class/sound/card$i/id) /usr/bin/espeakup >> /var/log/espeakup.log 2>&1 > + i=$(strip $ID) > + ALSA_CARD=$(cat > /sys/class/sound/card$i/id) /usr/bin/espeakup -V en >> /var/log/espeakup.log > 2>&1 and here… > - ALSA_CARD=$(cat /sys/class/sound/card$CARD/id) > /usr/bin/espeakup >> /var/log/espeakup.log 2>&1 > + ALSA_CARD=$(cat /sys/class/sound/card$CARD/id) > /usr/bin/espeakup -V en >> /var/log/espeakup.log 2>&1 and here? I don't think that's an issue with cherry-picking the relevant commit, since it doesn't seem to contain any indications the default voice is getting set to English? | commit eb7ae621d1db300e1159f48e149e11d85d372106 | Author: Samuel Thibault <[email protected]> | Date: Tue Nov 14 01:10:11 2017 +0100 | | Fix sound board selection | | * debian/espeakup-udeb.start: Fix case where card 0 does not have an id or | where cards have non-contiguous indexes. | * debian/espeakup-udeb.finish-install: Use card id in installed system | to avoid issues with card detection ordering. Not a blocker for me (from a d-i point of view), but from a release team point of view, I think that needs documenting (or stripping, if that wasn't intended or if it isn't actually needed for this p-u request). Cheers, -- Cyril Brulebois ([email protected]) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
