On Sat, 15 Jul 2017 21:23:58 +0100 Ian Jackson < ijack...@chiark.greenend.org.uk> wrote: > (resending with right list address) > > Maximiliano Curia writes ("stretch-pu: plasma 5.8.7 LTS pre-approval"): > > The source packages that I would like to update in stretch are: > > Thanks. I am not a RM but I am trying to help out by providing review > comments. I have reviewed this request. > > tl;dr: Most of them are very good. Two are questionable: > plasma-workspace > plasma-desktop > > One caveat for all the packages: they all had big translation updates. > I ignored these. I assume these are fine for stretch-pu. > > > In each case I have been relying on the accuracy not only of the > provided debdiff but the provided "packaging" diff and upstream > git log. I found the latter particularly helpful - thank you! > > Overall I would like to say that I am impressed with the associated > documentation, and what I saw of upstream relase processes. With the > two exceptions I mention above, I was convinced by the thoroughness of > the approach upstream. Even when I didn't understand the code > etc. myself, upstream seemed to be making decisions on the right basis > and with good review. > > > bluedevil/4:5.8.7-1+deb9u1 > > breeze-gtk/5.8.7-1+deb9u1 > > kde-cli-tools/4:5.8.7-1+deb9u1 > > kscreenlocker/5.8.7-1+deb9u1 > > plasma-pa/4:5.8.7-1+deb9u1 > > user-manager/4:5.8.7-1+deb9u1 > > kwin/4:5.8.7-1+deb9u1 > > libksysguard/4:5.8.7-1+deb9u1 > > systemsettings/4:5.8.7-1+deb9u1 > > These LGTM. I did notice a few things that are IMO not of concern: > > The urls > > https://gnuservers.com.ar/~maxy/debian/plasma_5.8.7_stretch-pu/kscreenlocker_5.8.4_5.8.7.upstream.gitlog > https://gnuservers.com.ar/~maxy/debian/plasma_5.8.7_stretch-pu/systemsettigns_5.8.4_5.8.7.upstream.gitlog > > referred to in the bug report are 404. The urls are wrong and should > be > > https://gnuservers.com.ar/~maxy/debian/plasma_5.8.7_stretch-pu/libksysguard_5.8.4_5.8.7.upstream.gitlog > https://gnuservers.com.ar/~maxy/debian/plasma_5.8.7_stretch-pu/systemsettings_5.8.4_5.8.7.upstream.gitlog > > Do you generate these requests by hand ?! > > Secondly, this in the changelog entry for libksysguard 4:5.8.7-1 is > rather odd: > | * Add new patch: Drop-html-markup-from-polkit-action-file.patch. > | Thanks to Michael Biebl for reporting (Closes: 696905) > ... > | * Drop upstream applied patch: Drop-html-markup-from-polkit-action-file.patch > and it confused me briefly. >
Hi, It turns out that the mix of 5.8.6 and 5.8.7 plasma parts leads to some extremely annoying issues, at least for me. The most noticeable are : - Massive memory leak in ksmserver (bug #881015) - From time to time the system does not detect my soundcard anymore. These issues did not appear prior to Debian 9.2 release so I strongly suspect that the mix of 5.8.6 and 5.8.7 libs triggered the issues. For the latter one I must stress that my GPU is detected as a soundcard as well, which is a normal behaviour. (NVidia GPU w/ 375.82 blob) Restarting KDE fixes the issues, but for the issue with ksmserver you have to kill ksmserver manually, and then run kill -9 -1 as the component becomes unresponsive when it stats leaking memory. So could you please make a full transition to 5.8.7 ? Thanks a lot !