On Wed, 28 Jun 2017 00:51:33 +0200, Cyril Brulebois wrote: > > I've prepared an update for libembperl-perl in jessie to fix #810655 > > there as well. The changes are just the targetted fix taken from -5 > > without changes. Full debdiff attached. > > > diff --git a/debian/changelog b/debian/changelog > > index b59bf9e..e296d69 100644 > > --- a/debian/changelog > > +++ b/debian/changelog > > @@ -1,3 +1,11 @@ > > +libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium > > + > > + [ Axel Beckert ] > > + * Drop hard a2enmod dependency on mod_perl in zembperl.load. mod_perl is > > + enabled by default anyways if installed. (Closes: #810655) > > + > > + -- gregor herrmann <gre...@debian.org> Fri, 19 May 2017 13:09:03 +0200 > > + > > I haven't matched this to code changes at first glance. For the sake of > clarity: this relates to the Depends → Recommends update, because code > was added to “apache2_invoke enmode perl” where needed?
Thanks for asking; this made me look at the changes again, and made
me realize that I made a mistake (I took only one of Axel's commits
between 2.5.0-4 and 2.5.0-5 but there were actually three). Sorry for
that.
> (The second sentence makes it look like this /was/ the case already,
> while this seems to /become/ the case with this particular upload
> AFAIUI.)
The problem in #810655, as I understand it, is that d/control has
libapache2-mod-perl2 in Recommends (which is correct as embperl
doesn't require it) but that embperl's
/etc/apache2/mods-available/zembperl.load unconditionally tried to
load mod_perl.
Axel has in a later commit removed the changes in libembperl-perl.postinst
again, after verifying that embperl installs without mod_perl, with
mod_perl installed and activated and with mod_perl installed but
disabled.
So the only remaining code change is actually:
#v+
--- a/debian/zembperl.load.in
+++ b/debian/zembperl.load.in
@@ -1,6 +1,6 @@
# The sucky "zembperl" name is so we load after perl
-# Depends: perl
+# Recommends: perl
<IfModule mod_perl.c>
LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
#v-
I've now tentatively changed d/changelog to say
#v+
* Change hard dependency on mod_perl in zembperl.load to Recommends.
mod_perl is not required, and is enabled by default anyway if it is
installed.
This change matches the package dependencies and fixes an installation
failure when libapache2-mod-perl2 is not installed.
(Closes: #810655)
#v-
Does this make sense?
I'm attaching the full new debdiff, and I'm looping in Axel for a
sanity check.
Cheers,
gregor
--
.''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Tom Waits: Sins Of My Father
diff --git a/debian/changelog b/debian/changelog index b59bf9e..b2e9d48 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium + + [ Axel Beckert ] + * Change hard dependency on mod_perl in zembperl.load to Recommends. + mod_perl is not required, and is enabled by default anyway if it is + installed. + This change matches the package dependencies and fixes an installation + failure when libapache2-mod-perl2 is not installed. + (Closes: #810655) + + -- gregor herrmann <gre...@debian.org> Fri, 19 May 2017 13:09:03 +0200 + libembperl-perl (2.5.0-4) unstable; urgency=low [ Salvatore Bonaccorso ] diff --git a/debian/zembperl.load.in b/debian/zembperl.load.in index ce9542b..91bb120 100644 --- a/debian/zembperl.load.in +++ b/debian/zembperl.load.in @@ -1,6 +1,6 @@ # The sucky "zembperl" name is so we load after perl -# Depends: perl +# Recommends: perl <IfModule mod_perl.c> LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
signature.asc
Description: Digital Signature
