Hi Raphaël, Am 17.06.2017 um 19:59 schrieb Michael Biebl: > Am 06.06.2017 um 17:31 schrieb Raphaël Hertzog: >> +[Service] >> +Type=oneshot ... > Hm, so you just wrapped the sysv init script, but didn't actually > provide a native systemd unit. > Why is the unit generated by systemd-sysv-generator not sufficient?
Julien pointed out on IRC, that you changed to Type=oneshot to disable the start/stop timeouts and probably because Type=oneshot is more appropriate for schroot. The reasoning for the latter should be documented in the changelog though. I would suggest to simply ship a drop-in snippet for schroot, which sets the Type and Timeout. For that create a file /lib/systemd/system/schroot.service.d/timeout.conf (feel free to choose a better name), containing: [Service] Type=oneshot TimeoutSec=infinity Unfortunately, you currently need to explicitly specifiy the timeout for SysV generated service files due to [1], i.e. simply setting Type=oneshot for SysV generated unit files is not sufficient. I thinks this would be a nicer solution as it is more minimal and focuses on the actual necessary changes. It also makes it more obvious that eventually this package should be converted to use proper service files. I always cringe at packages shipping "native" service files which only run the SysV init scripts. Regards, Michael [1] https://github.com/systemd/systemd/issues/6143 -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
