Hello Adrian, Thanks for pointing this out.
I've little knowledge in ARM dev.
I've searched for memory barrier implementations examples in debian
packages source code, but I was clearly presumptuous claiming to fix the
build properly.
Do you have any pointer about proper memory barriers implementations ?
I'd really like to fix armel build and learn about this architecture.
Regards,
Jean Baptiste
On 13/06/2017 12:49, Adrian Bunk wrote:
> On Mon, Jun 12, 2017 at 09:58:07PM +0800, Aron Xu wrote:
>> ...
>> @@ -1,3 +1,11 @@
>> +trafficserver (7.0.0-5+deb9u1) UNRELEASED; urgency=medium
>> ...
>> + * Add a patch to fix arm build
>> +
>> + -- Jean Baptiste Favre <deb...@jbfavre.org> Mon, 29 May 2017 14:45:52
>> +0200
>> ...
>> ++ #if defined(__ARM_ARCH_4__) \
>> ++ || defined(__ARM_ARCH_4T__) \
>> ++ || defined(__ARM_ARCH_5__) \
>> ++ || defined(__ARM_ARCH_5E__) \
>> ++ || defined(__ARM_ARCH_5T__) \
>> ++ || defined(__ARM_ARCH_5TE__) \
>> ++ || defined(__ARM_ARCH_5TEJ__) \
>> ++ || defined(__ARM_ARCH_6__) \
>> ++ || defined __ARM_ARCH_6J__ \
>> ++ || defined(__ARM_ARCH_6K__) \
>> ++ || defined(__ARM_ARCH_6Z) \
>> ++ || defined(__ARM_ARCH_6ZK__) \
>> ++ || defined(__ARM_ARCH_6T2__)
>> ++ #if defined(__thumb__)
>> ++ // This is just a placeholder and almost certainly not sufficient.
>> ++ #define mb() __asm__ __volatile__ ("" : : : "memory");
>> ++ #define rmb() __asm__ __volatile__("" : : : "memory")
>> ++ #define wmb() __asm__ __volatile__("" : : : "memory")
>> ...
>
> This would change the code from not building to being known broken on armel.
>
> That's IMHO worse than before.
>
> cu
> Adrian
>
signature.asc
Description: OpenPGP digital signature
