Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Please unblock package cacti In cacti 0.8.8h+ds1-9 I fixed a regression since PHP 7 became the default. In the non-default (but relative common) situation where one wants to monitor some variable with a higher frequency than once per minute, the poller would die on calling split() which was deprecated in PHP 7, filed in bug 860271. Debdiff attached. unblock cacti/0.8.8h+ds1-9 - -- System Information: Debian Release: 9.0 APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'testing'), (200, 'experimental'), (200, 'testing'), (50, 'experimental'), (50, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-2-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAljwc5wACgkQnFyZ6wW9 dQo1Jgf+M62bB29LdleyDurk4svA18T2Cuw0ur+Br338xNvg0XplrrqE95Fz/J58 L1BOavJHXN9szM3KUo+0FB3DTi5kvqu2A7bZslbA26J418e1hafq6YDX6TyufpT9 0zZsG4lugaZayspKdDYToTpnVTloHk1/IfEp7p4DUE8uIyDgdRsPK5/H1NKscFsz oGCUrSLrYknrmz4hwcV58xynaB6/47ZYpdCzmx1RFzP1F19rN/nK8oLxTrNjK33l O+2ZF1XVbi79cxAN5QCk/BrTD7mzO4kiQOOs2Lmjk3KUjSMl0UusOvgk9oJhrnyf K9dL0gcJ7Q2x87dX2XmtzMX3g/LLUA== =eaEQ -----END PGP SIGNATURE-----
diff -Nru cacti-0.8.8h+ds1/debian/changelog cacti-0.8.8h+ds1/debian/changelog --- cacti-0.8.8h+ds1/debian/changelog 2016-12-14 21:20:24.000000000 +0100 +++ cacti-0.8.8h+ds1/debian/changelog 2017-04-13 22:05:30.000000000 +0200 @@ -1,3 +1,10 @@ +cacti (0.8.8h+ds1-9) unstable; urgency=medium + + * Add enable_faster_polling_than_cron.patch to replace the use of the + deprecated split() function (Closes: #860271) + + -- Paul Gevers <elb...@debian.org> Thu, 13 Apr 2017 22:05:30 +0200 + cacti (0.8.8h+ds1-8) unstable; urgency=medium * Depend on libjs-jquery-jstree instead of using embedded version diff -Nru cacti-0.8.8h+ds1/debian/patches/enable_faster_polling_than_cron.patch cacti-0.8.8h+ds1/debian/patches/enable_faster_polling_than_cron.patch --- cacti-0.8.8h+ds1/debian/patches/enable_faster_polling_than_cron.patch 1970-01-01 01:00:00.000000000 +0100 +++ cacti-0.8.8h+ds1/debian/patches/enable_faster_polling_than_cron.patch 2017-04-13 22:04:42.000000000 +0200 @@ -0,0 +1,23 @@ +Description: split() is deprecated in PHP 7, causing the code to fail +Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027 +Bug-Debian: https://bugs.debian.org/860271 +Source: https://github.com/Cacti/cacti/commit/6b5931130770cdfa5baa68c43a913dcabf1c3970 + +Index: cacti/poller.php +=================================================================== +--- cacti.orig/poller.php ++++ cacti/poller.php +@@ -451,11 +451,9 @@ while ($poller_runs_completed < $poller_ + + /* sleep the appripriate amount of time */ + if ($poller_runs_completed < $poller_runs) { +- list($micro, $seconds) = split(' ', microtime()); +- $plugin_start = $seconds + $micro; ++ $plugin_start = microtime(true); + api_plugin_hook('poller_bottom'); +- list($micro, $seconds) = split(' ', microtime()); +- $plugin_end = $seconds + $micro; ++ $plugin_end = microtime(true); + if (($sleep_time - ($plugin_end - $plugin_start)) > 0) { + usleep(($sleep_time - ($plugin_end - $plugin_start)) * 1000000); + } diff -Nru cacti-0.8.8h+ds1/debian/patches/series cacti-0.8.8h+ds1/debian/patches/series --- cacti-0.8.8h+ds1/debian/patches/series 2016-12-14 21:16:53.000000000 +0100 +++ cacti-0.8.8h+ds1/debian/patches/series 2017-04-13 21:37:14.000000000 +0200 @@ -12,3 +12,4 @@ make_cacti_sql_mode-strict_compatible.patch CVE-2016-2313-guest-auth.patch fix_export_for_debian_packages.patch +enable_faster_polling_than_cron.patch
