Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
unblock dh-make-perl/0.94
Please unblock package dh-make-perl 0.94.
This upload fixes #856532, a regression introduced by some
refactoring in 0.93 in a rarely used code path (that's why we didn't
catch it). The upload only adds a trivial missing method.
Changelog:
dh-make-perl (0.94) unstable; urgency=medium
[ Carnë Draug ]
* Fix "Error: Can't locate object method "get_user"" Create new
DhMakePerl::Command::Packaging->get_user method which is used when
DEBEMAIL and EMAIL are unset. Fixes regression from 0.93.
(Closes: #856532)
-- gregor herrmann <gre...@debian.org> Thu, 16 Mar 2017 21:22:51 +0100
I'm attaching the diff against 0.93, slightly redacted to remove the
redundant $VERSION changes which are present in each perl module.
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAljK+elfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgYqlhAAstrmbvq+CxrV8rfJS2edfATPNC+Y2ssUrDgmyaNg5XB+L65O4wgynONO
xhcW3zOOQia/nzLN3hfZhGSodMLV+unkiL6rXhO11BHD2S7NT2fLCviBcrjstt1I
HJJv+m//cgExe9+zGtM+VZ/bfMrHnKR2DBKB4UyBDpz7+/pMIb9n5qjETQLyiYOU
sdCpwnxa178oOEx2Zyqiw1fF1OMNJfw8zxPlqw65wDf9j5OF9p3Ln8lNqzKLFNWQ
hQd70woqw7kxZAiF4NaE3t0n9Z0vyiUm1otK4IlZbLIIDR2wIDODy9EPKFCC4/A5
GQRAcbqtE2hOAq3zcb/rIij4Wepo8SSh4XvOc4/Fr4xO61T8awvsQahEsa5MhjHN
6UVVBQgjJXNGBAEO58Y14z2aMkZ92KW8wKGyRy3I5w89ZKs2OuYmYDwXZHohwwIh
JRq2VjreC+qw2ynez6PK/u/58mUGevcqmfsfdcv1cyH1kb81vCPwkoI2AQnlDD/k
OOfZJzvwqBI5DDRZvDTa3J2b8dIFJME8kFpio8OTyKDq8zB1ii3rtoA7RkczlKck
0otjN10TMNROo3nnWUlgjHeqTaEzs89tf2VSKUIjs5FDChjsonnrBnzSg9QpVmDQ
mau5dE7tNPY3jMz/1yWRE2p7UO6GMFtv2ZMu/iIpz9K/cepFVDs=
=EM5x
-----END PGP SIGNATURE-----
diff -Nru dh-make-perl-0.93/debian/changelog dh-make-perl-0.94/debian/changelog
--- dh-make-perl-0.93/debian/changelog 2017-01-26 20:26:57.000000000 +0100
+++ dh-make-perl-0.94/debian/changelog 2017-03-16 21:22:51.000000000 +0100
@@ -1,3 +1,13 @@
+dh-make-perl (0.94) unstable; urgency=medium
+
+ [ Carnë Draug ]
+ * Fix "Error: Can't locate object method "get_user"" Create new
+ DhMakePerl::Command::Packaging->get_user method which is used when
+ DEBEMAIL and EMAIL are unset. Fixes regression from 0.93.
+ (Closes: #856532)
+
+ -- gregor herrmann <gre...@debian.org> Thu, 16 Mar 2017 21:22:51 +0100
+
dh-make-perl (0.93) unstable; urgency=medium
[ gregor herrmann ]
diff -Nru dh-make-perl-0.93/lib/DhMakePerl/Command/Packaging.pm
dh-make-perl-0.94/lib/DhMakePerl/Command/Packaging.pm
--- dh-make-perl-0.93/lib/DhMakePerl/Command/Packaging.pm 2017-01-26
20:26:57.000000000 +0100
+++ dh-make-perl-0.94/lib/DhMakePerl/Command/Packaging.pm 2017-03-16
21:22:51.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
-our $VERSION = '0.93';
+our $VERSION = '0.94';
use feature 'switch';
@@ -119,6 +119,10 @@
return $self->main_file('Makefile.PL');
}
+sub get_user {
+ return $ENV{LOGNAME} || $ENV{USER};
+}
+
sub get_email {
my $self = shift;
my $email = $self->cfg->email;
@@ -138,7 +142,7 @@
my $self = shift;
my $name;
- my $user = $ENV{LOGNAME} || $ENV{USER};
+ my $user = $self->get_user;
my $pwnam = getpwuid($<);
die "Cannot determine current user\n" unless $pwnam;
if ( defined $ENV{DEBFULLNAME} ) {
