Package: release.debian.org Severity: normal Tags: jessie User: release.debian....@packages.debian.org Usertags: pu
Hi irqbalance on jessie ist still affected by #784391, causing irqbalance to spam logs under certain conditions where affinity_hint subset is empty. Attached the proposed debdiff. Can you consider it to be accepted for the next jessie point release? Regards, Salvatore -- System Information: Debian Release: 8.7 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
diff -Nru irqbalance-1.0.6/debian/changelog irqbalance-1.0.6/debian/changelog --- irqbalance-1.0.6/debian/changelog 2014-09-10 03:44:54.000000000 +0200 +++ irqbalance-1.0.6/debian/changelog 2017-03-16 11:14:03.000000000 +0100 @@ -1,3 +1,10 @@ +irqbalance (1.0.6-3+deb8u1) jessie; urgency=medium + + * Non-maintainer upload. + * Only warn once for affinity hint subset empty irqs (Closes: #784391) + + -- Salvatore Bonaccorso <car...@debian.org> Thu, 16 Mar 2017 11:14:03 +0100 + irqbalance (1.0.6-3) unstable; urgency=medium * Merge 1.0.6-2ubuntu1. diff -Nru irqbalance-1.0.6/debian/patches/only-warn-once-for-affinity-hint-subset-empty-irqs.patch irqbalance-1.0.6/debian/patches/only-warn-once-for-affinity-hint-subset-empty-irqs.patch --- irqbalance-1.0.6/debian/patches/only-warn-once-for-affinity-hint-subset-empty-irqs.patch 1970-01-01 01:00:00.000000000 +0100 +++ irqbalance-1.0.6/debian/patches/only-warn-once-for-affinity-hint-subset-empty-irqs.patch 2017-03-16 11:14:03.000000000 +0100 @@ -0,0 +1,44 @@ +Description: Only warn once for affinity hint subset empty irqs +Origin: upstream, https://github.com/Irqbalance/irqbalance/commit/c9e5f36fe91d2d04d013d96f1093419245585de7 + https://github.com/Irqbalance/irqbalance/commit/2026594e1bc171baf72b56f1b76222fc9b57416c +Bug: https://github.com/Irqbalance/irqbalance/pull/17 +Bug-Debian: https://bugs.debian.org/784391 +Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/irqbalance/+bug/1321425 +Author: posophe <p.drou...@gmail.com> +Reviewed-by: Salvatore Bonaccorso <car...@debian.org> +Last-Update: 2017-03-16 +Applied-Upstream: v1.0.9 +--- + +--- a/activate.c ++++ b/activate.c +@@ -84,11 +84,14 @@ static void activate_mapping(struct irq_ + if ((hint_policy == HINT_POLICY_SUBSET) && + (!cpus_empty(info->affinity_hint))) { + cpus_and(applied_mask, applied_mask, info->affinity_hint); +- if (!cpus_intersects(applied_mask, unbanned_cpus)) +- log(TO_ALL, LOG_WARNING, +- "irq %d affinity_hint subset empty\n", +- info->irq); +- else ++ if (!cpus_intersects(applied_mask, unbanned_cpus)) { ++ if (!info->warned) { ++ info->warned = 1; ++ log(TO_ALL, LOG_WARNING, ++ "irq %d affinity_hint subset empty\n", ++ info->irq); ++ } ++ } else + valid_mask = 1; + } else { + valid_mask = 1; +--- a/types.h ++++ b/types.h +@@ -63,6 +63,7 @@ struct irq_info { + uint64_t load; + int moved; + struct topo_obj *assigned_obj; ++ unsigned int warned; + }; + + #endif diff -Nru irqbalance-1.0.6/debian/patches/series irqbalance-1.0.6/debian/patches/series --- irqbalance-1.0.6/debian/patches/series 2013-06-06 12:22:45.000000000 +0200 +++ irqbalance-1.0.6/debian/patches/series 2017-03-16 11:14:03.000000000 +0100 @@ -1 +1,2 @@ irqbalance.1.patch +only-warn-once-for-affinity-hint-subset-empty-irqs.patch
