On Tue, 02 Aug 2011, Giovanni Mascellani wrote:
> diff --git a/patchtracker/Patch.py b/patchtracker/Patch.py
> index 80ad8dc..0f90e2f 100644
> --- a/patchtracker/Patch.py
> +++ b/patchtracker/Patch.py
> @@ -177,6 +177,8 @@ class Quilt30PatchSeries (GenericPatchSeries):
> try:
> try:
> series_fh = self.tarfh.extractfile("debian/patches/debian.series")
> + # FIXME - From dpkg-source manpage it appears that when both files
> + # exist, patch listed in both must be applied
> except KeyError:
> series_fh = self.tarfh.extractfile("debian/patches/series")
> except KeyError:
I think you have misread the manual page. The or is really a "xor".
Thus the code is fine as is.
Feel free to send a suggestion for a better wording of the dpkg-source
manual page. :)
> + # Awful printing:
> + json.dump(packages, sys.stdout)
Hum the PTS doesn't use JSON yet (AFAIK), YAML might thus be a better
choice.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Follow my Debian News ▶ http://RaphaelHertzog.com (English)
▶ http://RaphaelHertzog.fr (Français)
--
To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110802140935.ga23...@rivendell.home.ouaza.com
