Bug#1120460: storebackup: Use of uninitialized value $ENV{"USER"} in string

[Francesco Potortì]

I discovered that when called from Cron, USER is not set (but LOGNAME is).

This patch corrects the problem:

--- storeBackup~        2025-08-27 12:21:58.000000000 +0200
+++ storeBackup 2025-11-25 17:10:11.009385743 +0100
@@ -136,7 +136,7 @@
 
 
 my $storeBackupUpdateBackup_prg = 'storeBackupUpdateBackup.pl';
-my $lockFile = ($ENV{'USER'} eq 'root') ?     # default value
+my $lockFile = ($ENV{'LOGNAME'} eq 'root') ?     # default value
                '/var/lock/storeBackup.lock' :
                $ENV{'HOME'} . '/storeBackup.lock';
 my (@compress) = ('bzip2');               # default value
--- storeBackupDel~     2025-08-27 12:21:58.000000000 +0200
+++ storeBackupDel      2025-11-25 17:10:05.985466090 +0100
@@ -99,7 +99,7 @@
 require 'fileDir.pl';
 require 'humanRead.pl';
 
-my $lockFile = ($ENV{'USER'} eq 'root') ?     # default value
+my $lockFile = ($ENV{'LOGNAME'} eq 'root') ?     # default value
                '/var/lock/storeBackup.lock' :
                $ENV{'HOME'} . '/storeBackup.lock';
 my $keepAll = '30d';
--- storeBackupUpdateBackup~    2025-08-27 12:21:58.000000000 +0200
+++ storeBackupUpdateBackup     2025-11-25 17:09:58.597584235 +0100
@@ -99,7 +99,7 @@
 require 'fileDir.pl';
 require 'humanRead.pl';
 
-my $lockFile = ($ENV{'USER'} eq 'root') ?     # default value
+my $lockFile = ($ENV{'LOGNAME'} eq 'root') ?     # default value
                '/var/lock/storeBackup.lock' :
                $ENV{'HOME'} . '/storeBackup.lock';
 my $checkSumFile = '.md5CheckSums';

-- 
Francesco Potortì (ricercatore)        Mobile: +39.348.8283.107      
ISTI - Area della ricerca CNR          Teams:  wnlabisti             
via G. Moruzzi 1, I-56124 Pisa         Web:    http://fly.isti.cnr.it
(gate 20, 1st floor, room C71)         ISPIN:  https://ieee-jispin.org/