Control: retitle -1 elk: FTBFS with libxaw 1.0.16: error: passing argument 2 of ‘XawListChange’ from incompatible pointer type
On 11/30/24 19:11, Santiago Vila wrote:
I've found that the attached patch would fix the ftbfs problem, but I'd like a second opinion.
libxaw-1.0.16 has this API change: diff -Nru libxaw-1.0.14/include/X11/Xaw/List.h libxaw-1.0.16/include/X11/Xaw/List.h --- libxaw-1.0.14/include/X11/Xaw/List.h 2021-03-27 18:40:21.000000000 +0100 +++ libxaw-1.0.16/include/X11/Xaw/List.h 2024-03-10 18:39:48.000000000 +0100 @@ -161,13 +161,13 @@ ... void XawListChange ( Widget w, - _Xconst char **list, + String *list, int nitems, int longest, #if NeedWidePrototypes Is this also an ABI change? The soversion is unchanged. I'm too lazy to lookup that X11 String type right now ... So I don't think (const char **) ==> (char **) is correct. Please also bump the B-D: libxaw7-dev to (>= 2:1.0.16) https://codesearch.debian.net/search?q=XawListChange&literal=1 shows e.g. texlive-bin as another potential candidate for this bug texlive-bin_2024.20240313.70630+ds-5/debian/patches/texlive-bin-20230311-typecasts.patch /* delete and re-create list */ ASSERT(total_pages <= (int)page_info.index_size, ""); - XawListChange(LIST_WIDGET, page_info.page_labels, 0, + XawListChange(LIST_WIDGET,(const char **) page_info.page_labels, 0, MAX(button_width, pagelist_width), False); PathRank: 0.5, Final: 0.5891354 how did they solve it? I didn't find a corresponding bug (or upload since the xaw change) Has there been an archive wide rebuild of the libxaw rdepends since 1.0.16? Andreas
