Source: splitpatch Version: 1.0+20190128+git3b2edf2-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi, Whilst working on the Reproducible Builds effort [0] we noticed that splitpatch could not be built reproducibly. This is because my previous patch used $$(shell …) instead of $(shell …) (note the change of number of dollar signs...) so that we were still embedding today's date into the pod2man --center argument. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
--- a/debian/patches/reproducible-build.patch 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/reproducible-build.patch 2019-11-04 10:30:30.092883126 -0800 @@ -0,0 +1,18 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2019-11-04 + +--- splitpatch-1.0+20190128+git3b2edf2.orig/man/pod2man.mk ++++ splitpatch-1.0+20190128+git3b2edf2/man/pod2man.mk +@@ -39,9 +39,9 @@ MANSECT ?= 1 + + DATE_FMT = %Y-%m-%d + ifdef SOURCE_DATE_EPOCH +-PODCENTER ?= $$(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)") ++PODCENTER ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)") + else +-PODCENTER ?= $$(date "$(DATE_FMT)") ++PODCENTER ?= $(date "$(DATE_FMT)") + endif + + # Directories --- a/debian/patches/series 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/series 2019-11-04 10:30:28.792869453 -0800 @@ -0,0 +1 @@ +reproducible-build.patch