Your message dated Fri, 02 Dec 2016 22:49:02 +0000 with message-id <e1ccwda-000eao...@fasolo.debian.org> and subject line Bug#775989: fixed in live-build 1:20161202 has caused the Debian Bug report #775989, regarding live-build: Disable chroot_archive remove early exit to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 775989: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775989 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: live-build Version: 5.0~a2-1 Tags: patch Patch attached to disable the early exit in chroot_archives removal when chroot and binary mirrors are identical, which incorrectly prevents some of the removal code being executed. I've had this sitting around in my WIP 'restructuring' branch for a while, and a mailing list discussion just prompted me to extract and submit it. As noted in the fixme comment it introduces, the implementation of the patch is just a quick fix and there are additional issues to be addressed in this script, which I intend to resolve as part of the restructuring work.commit cfb644e22512dc693e682d52532d57e4d3064edc Author: jnqnfe <jnq...@gmail.com> Date: Sat Nov 29 02:22:25 2014 +0000 Temporarily disable early exit in 'chroot_archives remove'. diff --git a/scripts/build/chroot_archives b/scripts/build/chroot_archives index 4c51cd7..8c2e192 100755 --- a/scripts/build/chroot_archives +++ b/scripts/build/chroot_archives @@ -551,17 +551,30 @@ then Chroot_unbind_path chroot "$(echo ${LB_PARENT_MIRROR_CHROOT} | sed -e 's|file:||')" fi - # Configure generic indices - # Don't do anything if it's not required - if [ "${LB_PARENT_MIRROR_CHROOT}" = "${LB_PARENT_MIRROR_BINARY}" ] && \ - [ "${LB_PARENT_MIRROR_CHROOT_SECURITY}" = "${LB_PARENT_MIRROR_BINARY_SECURITY}" ] && \ - [ ! -d chroot/root/packages ] - then - # Removing stage file - rm -f .build/chroot_archives - - exit 0 - fi +# FIXME: +# Temporarily disabling this early-exit code that was put here for efficiency, +# but which causes a lot of code to be skipped that really shouldn't be skipped. +# To elaborate, the regeneration of the archive source file isn't needed if the +# mirrors are the same, however blocking the rest causes the following issues: +# - Small bits of code towards the end, such as that needed to honor the +# --apt-indices parameter when set to false, are not executed. +# - This script is executed multiple times throughout the process, and should +# toggle the apt config cleanly between chroot and binary modes. It does not +# do this perfectly though. Part of the problem is this early exit, however +# the issue also extends into the install (chroot config) code above not +# removing the remove (binary) config components correctly, and neither +# removing the keys each other installs. + # # Configure generic indices + # # Don't do anything if it's not required + # if [ "${LB_PARENT_MIRROR_CHROOT}" = "${LB_PARENT_MIRROR_BINARY}" ] && \ + # [ "${LB_PARENT_MIRROR_CHROOT_SECURITY}" = "${LB_PARENT_MIRROR_BINARY_SECURITY}" ] && \ + # [ ! -d chroot/root/packages ] + # then + # # Removing stage file + # rm -f .build/chroot_archives + + # exit 0 + # fi # Cleaning apt list cache rm -rf chroot/var/lib/apt/lists
--- End Message ---
--- Begin Message ---Source: live-build Source-Version: 1:20161202 We believe that the bug you reported is fixed in the latest version of live-build, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 775...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Raphaël Hertzog <hert...@debian.org> (supplier of updated live-build package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 02 Dec 2016 23:33:45 +0100 Source: live-build Binary: live-build Architecture: source Version: 1:20161202 Distribution: unstable Urgency: medium Maintainer: Debian Live <debian-l...@lists.debian.org> Changed-By: Raphaël Hertzog <hert...@debian.org> Description: live-build - Live System Build Components Closes: 731709 773775 773833 774730 774807 775989 790033 801379 801712 806782 808048 809699 816204 818916 831379 832998 Changes: live-build (1:20161202) unstable; urgency=medium . [ Raphaël Hertzog ] * Officially adopt the package. Closes: #808048 * Better handle empty package lists. * Drop ixp4xx from available armel flavors, the image has been gone since linux 3.17. * Add symlinks for libgpl.c32 and libmenu.c32 which are required by the "Hardware Detection Tool (HDT)" menu entry that live-build adds in the advanced menu. * Add EFI boot support with grub-efi, thanks to Adrian Gibanel Lopez. Closes: #731709 * Fix usage of config/packages.chroot/*.deb that has been broken by the switch to GnuPG2 by default by no longer using GnuPG but relying on APT's trusted=yes attribute instead. Thus we no longer have remaining key in /etc/apt/trusted.gpg after building. Closes: #816204 * Try to reuse /isolinux/splash.png in default grub configuration. * Drop debian/source/{local-options,options} as they are no longer needed. * Pass components to debootstrap --second-stage. Closes: #806782 Thanks to Sjoerd Simons <sjoerd.sim...@collabora.co.uk> for the patch. * Fix behaviour of (undocumented) "#nif" conditional test. Closes: #801379 Thanks to Erik Cumps <erik.cu...@esaturnus.com> for the patch. * Export SOURCE_DATE_EPOCH when running chroot commands. Closes: #832998 Thanks to Chris Lamb <la...@debian.org> for the patch. * Set xorriso's "modification time" to SOURCE_DATE_EPOCH. Closes: #831379 Thanks to Chris Lamb <la...@debian.org> for the patch. * Support “lb config --debootstrap-script <script>” to use an alternate bootstrap script when running debootstrap. Thanks to Sjoerd Simons <sjo...@debian.org> for the initial patch. Closes: #790033 * Manual pages updates by jnqnfe. Closes: #774730 * Drop left-over translation files for removed lb_testroot command. * Get rid of useless bootstrap_archive-keys script. Closes: #773775 * Drop an optimization in chroot_archives that has undesired side-effects. Thanks to jnqnfe for the patch. Closes: #775989 * Drop gpgv and debian-keyring from Suggests. * Fix Check_installed function when checking against host. Thanks to jnqnfe for the report. Closes: #774807 * Bump debhelper compat level to 10. * Bump Standards-Version to 3.9.8. * Use a grub theme that integrates reasonably well with the current background picture. * Default for LB_UNION_FILESYSTEM is now "overlay" just like in live-boot. * Update the way we generate the version of live-build that is displayed by lb --version. * Instead of renaming kernel for syslinux, create hardlinks. * Simplify grub configuration code to use only long kernel names. Put advanced options in a submenu. Use distro-agnostic labels. . [ Kristian Klausen ] * Include ext{3,4} journal size when calculating image size. Closes: #801712 * Switch d-i.debian.org URIs from http to https. Closes: #809699 * Fix typo in binary_syslinux. Closes: #818916 * Correct syslinux/extlinux mbr.bin path. Closes: #773833 Checksums-Sha1: e783fa6b0d05665b6f469a129c9879fd09bd7eaa 1369 live-build_20161202.dsc aafba09d63b5272b406faeb78f29c0693ad2403f 352376 live-build_20161202.tar.xz Checksums-Sha256: 794d5ac54770ee627c1e65c3a97db626f426d3e0414045fa7f4ee34e888b3ecc 1369 live-build_20161202.dsc e3930f826ecd3a3b8b49df56f7c130c087c9268fe8dda16aa340be15b1c9b148 352376 live-build_20161202.tar.xz Files: b0b7bc9164340ae43a2fe2654692fa29 1369 misc optional live-build_20161202.dsc 39cb06ac14afe4e6c8de32aeeac6e08a 352376 misc optional live-build_20161202.tar.xz -----BEGIN PGP SIGNATURE----- Comment: Signed by Raphael Hertzog iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAlhB9vcACgkQA4gdq+vC mrnfbQf+K+CbLMaL6+aCMvN7UI9JtDOvB6K9wu8dDnNUNLJcRqgvdx+03DfU08oD X3UhZWJGhxVUvVIM+HSt/JXi9KKCfOxG4WnCiEzj1ewYihjgD2SICh1OrsL/SswS dCwNAPGJYfWOFwvESBbf3Q6XdVuKqj17ImjICtYfsirD/1vuQU4bCepi1ZJShXrs RdDpeVbzsti4hJlMax9xTxmmmercVq2fm81X5CHSnGh/IRIc77akJH5D+vRhZSM1 aAEQANEzof4TySnk7I62QJn0ik/Uykuk2w8DoRH6f3fZCOxagnm0bHW9WzhP6Zu/ dtD4kG3TrZAikkCeStx6hxGZxhFD8A== =vy9F -----END PGP SIGNATURE-----
--- End Message ---
