hi Arian, I took a look at the python-pgvector package, up for sponsorship in the Python team:
* there's diff between the orig tarball pulled in by uscan and the one generated from the pristine-tar branch: (output from tardiff -m -s) + .github + .github/workflows + .github/workflows/build.yml + .gitignore + CHANGELOG.md + Makefile - PKG-INFO + examples [...] - pgvector.egg-info [...] + requirements.txt - setup.cfg + tests/__init__.py * changelog: for an all new package, please keep only the initial release entry that closes the ITP bug. * d/gbp.conf: why the 'sign-tags = False'? * control: (iirc) on the buildds, alternatives in build-deps aren't considered the same way you would expect them to when installing a binary package. * control: please mark test-only build-dependencies as such. * control: the upstream project is called pgvector-python, that could be used for the source package name in Debian as well. (info only) * control: doesn't having a build-dep on "postgresql-all" make the one on "postgresql" redundant? * control: the binary package seems to be missing most Python module dependencies apart from numpy: the code also imports asyncpg, django, peewee, psycopg, psycopg2, scipy, sqlalchemy but none of those appear as dependencies. * rules: "export PYBUILD_NAME=python-pgvector" - is that so? * autopkgtest: please avoid adding or duplicating any dependency that should exist on the binary package in the first place (see above), all that does is hide bugs. The only dependencies you want here are the binary package being tested, plus whatever is specifically needed for running the testsuite. For Python packages that typically includes python3-all as well as pytest or similar testing frameworks, and (in this case) the database server stuff. * autopkgtest: please test with all supported Python versions. The salsa CI logs show both 3.13 and 3.14 tested on build, but only 3.13 in the autopkgtest. * patches: 0001 says 'forwarded: not needed' but looks like it wouldn't do any harm upstream either? * lintian: no need to override lintian hits that are factually correct, even if you expect them to be fixed when your upstream pull request gets merged. Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail. [1]https://codesearch.debian.net/search?q=path%3Adebian%2Frules+for+pyvers+in+%24%28PYTHON3S%29&literal=1
pgpHJiFinUk0a.pgp
Description: OpenPGP digital signature
