Hi Mahangu, > Tested in clean chroot and Salsa CI also now passing. Ready for > re-review. > > Note: I made additional changes to get CI green (test configuration > via PYBUILD_TEST_ARGS/PYBUILD_BEFORE_TEST, pristine-tar, > Build-Depends adjustments). I'm still learning Debian packaging, so > I'd appreciate any feedback if these aren't the right approaches.
thanks for all those fixes, much better now. Don't worry if there's a lot of feedback, you didn't pick the easiest package to start out with packaging from scratch. Some issues remaining: * repo: upstream/0.65.2 tag still points to the old source import, should be moved to the newest one; see https://salsa.debian.org/python-team/packages/datasette/-/commits/upstream * vendored copy of pint gets installed into the binary pkg; you might want to add an entry to d/clean (datasette/vendored/*) to ensure it cannot be used or installed by accident. * control: there's still a load of unnecessary hardcoded python deps on binary pkg; you probably only need to keep markupsafe (or patch setup.py so it's picked up by dh_python/pybuild); everything else looks like it would be provided via ${python3:Depends}. * control: build-deps on python3-platformdirs, -typing-extensions, and -flex* were needed only for the vendored pint; with that out of the picture, these deps are unused and should be removed. * patches: remove-vendored-pint patch header contains boilerplate dep3 template. * rules: '--with python3' is redundant when build-depending on dh-sequence-python3. * rules: override_dh_auto_build -> execute_after_dh_auto_build? * copyright: the vendored copy of pint is still missing here. It must be included even if it's not used or installed, simply because it's shippped in the orig tarball. * some lintian hits need attention, particularly: (from https://salsa.debian.org/python-team/packages/datasette/-/jobs/8674686) I: datasette: unused-override application-in-library-section python [usr/bin/datasette] [usr/share/lintian/overrides/datasette:4] --> section already changed to 'database' I: datasette: package-contains-documentation-outside-usr-share-doc [usr/lib/python3/dist-packages/docs/*] --> these typically go in /usr/share/doc/<pkgname> W: datasette: package-contains-vcs-control-file [usr/lib/python3/dist-packages/docs/.gitignore] W: datasette: privacy-breach-generic [<script defer data-domain="docs.datasette.io" src="https://plausible.io/js/plausible.js";>] (https://plausible.io/js/plausible.js) [...] --> this appears to be an analytics script, simply patching it out should be fine * these lintian hits on the other hand deserve an override, given that the non-minified versions are in d/missing-sources: P: datasette source: source-contains-prebuilt-javascript-object [datasette/static/cm-resize-1.0.1.min.js] P: datasette source: source-contains-prebuilt-javascript-object [datasette/static/codemirror-5.57.0-sql.min.js] P: datasette source: source-contains-prebuilt-javascript-object [datasette/static/codemirror-5.57.0.min.js] P: datasette source: source-contains-prebuilt-javascript-object [datasette/static/sql-formatter-2.3.3.min.js] P: datasette source: source-contains-prebuilt-javascript-object [datasette/static/table.js] * why d/source/options extend-diff-ignore = "^setup\.cfg$" - does this get modifed somehow? Same question for d/source/include-binaries tests/spatialite.db? As always, once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail.
pgpzd7gM_DmSq.pgp
Description: OpenPGP digital signature
