Hi,
CC-ing the Python team.
> have you contacted upstream about this patch?
IMO, that's the role of the maintainer. If you'd put the package back in
the Python team, I'd do it: open a bug upstream, forward the patch, etc.
> do you have any references in the kernel code for this new path?
These are ACPI names, and a quick search shows ADP0 seem documented. The
main issue with the current python-psutil tests, looks like to be when a
battery is found, but no matching AC adapter. A quick look on the kernel
git log shows the presence of power_supply/ADPX there too. I don't think
it's needed to search more: ADP0 is in the kernel, that's for sure, and
needs to be supported in python-psutil.
> or a reason why sometimes you added ADP0 as the first item in the
> list, and others as the last one?
I didn't think this was important.
You may change the order if you prefer.
> 2 days? you may want to reassess your expectations, demands, and
> approach to other volunteers in the project.
It feels like you see an NMU as a punishment. It is not, it's the
opposite: it's helping having things done in time. The expectations are
having things in order before the freeze, I don't see what's wrong here.
If you have no time, just let someone else do it for you, unless you see
the patch as technically wrong. It's also ok to let the upload happen,
and correct whatever you want on a subsequent upload (like the ordering
that looks like bothering you).
> that still applies in this instance, so please do not NMU
> python-psutil.
I insist that this needs to be done in a correct timeframe. If you can't
do it in time, just accept the NMU, unless you are able to tell why it
is technically wrong.
>> Also, the old repository doesn't redirect to the new place: you
>> should have asked Salsa admins to move the package for you.
>
> If this is something you're interested in, i dont see why you couldnt
> reach out to the Salsa admins to ask them just that.
Maybe you missed the fact that *I AM* a Salsa admin? Though that's not
the point: you should have opened a ticket at:
https://salsa.debian.org/salsa/support
to ask one of the Salsa admins to move your repository, so it would have
had a redirection. We can't do it if the repository already exists.
These are the normal best practice. Never mind...
Cheers,
Thomas Goirand (zigo)
P.S: Sorry if my message breaks the reply-to: I've just copy/past from
the web display of the BTS.
