Simon,

On Friday, December 20, 2024 3:06:35 PM MST Simon Josefsson wrote:
> Hi Python Team,
> 
> I have prepared packaging of 'grpclib' and I'm new to Python packaging,
> so I would appreciate open minded review of how this is packaged:
> 
> https://salsa.debian.org/python-team/packages/python-grpclib
> 
> Please bring up stylistic concerns, for me to learn.  I plan to upload
> this to NEW shortly.
> 
> Some of the questions/concerns I have are:
> 
> - Do the /usr/bin binaries have to go in a separate package, or could
>   they be in the python3-grpclib binary package?  I believe they are
>   developer-only tools of limited applicability.
> 
> - Naming - right now it uses this style:
> 
> Source: python-grpclib
> Package: python3-grpclib
> Package: protoc-grpclib
> 
>   Does that make sense?  Upstream calls itself 'grpclib' but using
>   'python-grpclib' in Debian seems nicer.  I see there is a
>   'rustc-protoc' in the archive, maybe this should be
>   'python-grpclib-protoc' instead?  Or 'protoc-python-grpclib'?  Or
>   'protoc-grpclib-python'?
> 
> - This uses tarballs from pypi.debian.net, which isn't identical to
>   upstream's GitHub git archive.  It seems tests/ are missing.  I've
>   approached upstream about including them in the PyPI upload --
>   https://github.com/vmagamedov/grpclib/issues/200 -- but I'm not sure
>   what the best practices are here.  Is using the pypi.debian.net
>   tarball recommended?  Or do people package the github.com tarball
>   instead?  Or directly from git?  What do we do when some stuff is
>   missing from the PyPI archive?

I am not experienced enough with Python packaging to respond to your other 
questions, but I do know that many Python packages pull from github or gitlab 
when thinks like tests are missing from PyPI, so you should feel free to do so 
when needed.

> - Man pages are missing - the tools doesn't respond to -h or --help, I
>   suppose this is an upstream request, or are there any other ideas on
>   that?
> 
> - Others?
> 
> /Simon
> 
> Simon Josefsson <si...@josefsson.org> writes:
> > Package: wnpp
> > Severity: wishlist
> > Owner: Simon Josefsson <si...@josefsson.org>
> > X-Debbugs-Cc: debian-de...@lists.debian.org, debian-
pyt...@lists.debian.org
> > 
> > * Package name    : python-grpclib
> > 
> >   Version         : 2.0.0b7
> >   Upstream Author : Vladimir Magamedov, et al
> > 
> > * URL             : https://github.com/vmagamedov/grpclib
> > * License         : BSD-3-Clause
> > 
> >   Programming Lang: Python
> >   Description     : Pure-Python gRPC implementation for asyncio
> >  
> >  This is a Pure-Python gRPC implementation for asyncio.
> > 
> > https://salsa.debian.org/python-team/packages/python-grpclib
> > 
> > /Simon


-- 
Soren Stoutner
so...@debian.org

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to