Hi Alexandru,
On 2024-12-06 17:13:18, Alexandru Mihail wrote:
Pinging about (upload) my last mail, I cleaned up upstream mess on
psrecord now and I think it's ready for upload. Would really appreciate
your scrutiny one last time.
I am mostly happy now. There are two issues left:
1. The generated man page is not cleaned up. As a result the package
clean-up validation (see [0]) fails:
----------------------------------------------------------------------
diff /tmp/file-list.pre-build /tmp/file-list.post-build
-------------------------------------------------------
17c17
< /<<PKGBUILDDIR>>/debian directory 220
---
> /<<PKGBUILDDIR>>/debian directory 240
21a22
> /<<PKGBUILDDIR>>/debian/psrecord.1 regular file 1427
fbcd91b4cb61d6616892a323e65daee05a54131e6177ae5b81da9ee4276722a6
----------------------------------------------------------------------
Adding a line
rm -f debian/psrecord.1
to the override_dh_auto_clean target in debian/rules should fix this.
2. The timestamp of the changelog entry is older than the most recent
commit (excluding commits that modify the changelog file).
Bonus item (optional):
In my opinion the legibility of debian/rules files is increased by
adding empty lines between the various targets.
The same also applies to the license text in debian/copyright (cf. lines
3 and 6 of the upstream LICENSE file [1]). Please note that "empty"
lines in the "License" fields of debian/copyright files are denoted by a
dot (".") in the second column.
Best regards
Peter
[0] https://wiki.debian.org/sbuild#Validate_package_cleanup
[1]
https://github.com/astrofrog/psrecord/blob/cda423ed3fa00fadad66cd7a28ed342748d9f88e/LICENSE
