On Wed, Dec 30, 2020 at 4:50 PM Devops PK Carlisle LLC wrote: > The git is here: https://github.com/pkcarlislellc/git-papershaper
I don't intend to package nor sponsor this, but here is a review: Drop git- from the name of the GitHub repository. Add a git repository to the SourceForge project also and push to both repos. Remove the possibly non-free and or non-redistributable images in the git repository. If they are actually redistributable and freely licensed, please document the location where they were obtained from, their copyright owner and license. If they are non-redistributable then you will need to rewrite the history of the git repository to exclude them. Merge the two scripts into one supporting both versions of Python (or just drop the Python 2 one). IIRC you can use the print function in Python 2 by adding the line below. After that the remaining changes don't look necessary, or can be made conditional with sys.version_info. from future import print_function The first thing in the README.md should be a one-sentence description of what the program does. Drop the Google Code mention/link from the README.md. The README.md mentions that webcamgrab.txt was taken from another program, but doesn't mention the copyright/license information for the file anywhere. While the SourceForge project for the other program says GPLv3, the tarball containing the list of webcams doesn't mention any license. Change the GPL reference at the start of the README.md to mention which versions. The list of webcams is liable to get out of date, especially when shipped with the script, it might be a good idea to have continuous monitoring of the list, plus a way to auto-update it on end-user systems. Consider switching to the XDG standard for some of the paths: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html https://wiki.archlinux.org/index.php/XDG_Base_Directory https://github.com/srstevenson/xdg When I run check-all-the-things in the source tree, a number of the checks produce output that is worth reviewing. https://github.com/collab-qa/check-all-the-things/ grep -ri gimp codespell doc8 grep -r http: proselint spellintian pycodestyle pyflakes pylint vulture -- bye, pabs https://wiki.debian.org/PaulWise
