On April 19, 2020 3:24:17 PM UTC, "Félix Sipma" <felix+deb...@gueux.org> wrote:
>Hi Thomas,
>
>Thanks for the review, and it's nice to see you found a number of
>problems! I have to admit I did not prepare a new package since a long
>time, probably forgot a lot of things, and copied others from other
>packages of mine...
>
>On 2020-04-19 14:09+0200, Thomas Goirand wrote:
>>Hi Felix,
>>
>>Thanks for working on this. Here's my comments. I'm sorry that there's
>a
>>lot to say on what you did... :/
>>
>>On 4/19/20 11:53 AM, Félix Sipma wrote:
>>> dget -x
>
> https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.2.1-1.dsc
>>
>>Looking at your debian/copyright, I'd strongly suggest releasing the
>>Debian packaging under the same license. For me that's a blocker for
>>sponsoring the package (it may be ok for others to sponsor).
>
>OK. I prefer using GPL-3+, but nevermind, I would really like to get
>this package in sid soon. Other sponsors are still to be found, so I
>turned it to Expat.
As a member of the FTP Team, I see this situation from time to time. It's
usually not a serious problem, but I agree with Zigo on this.
Where it becomes problematic is when code in debian/ becomes intermingled with
the installed upstream code. One has to look at the license of both upstream
and debian/ to determine the effective license of the package. If the licenses
are incompatible, then the binary isn't distributable. I have seen this happen.
Aligning the license of the packaging with the upstream license makes it all
much simpler.
...
>>Also, please remove:
>>
>>[import-orig]
>>merge-mode = replace
>>
>>from debian/gbp.conf. This is typically something that goes into
>>~/.gbp.conf rather than on individual packages.
>
>I don't agree with you on this one. To me, this kind of setting should
>be put in the package, to have an uniform way of updating/building/etc.
>
>a given package, whoever the uploader could be.
>
...
>fixed the issues you found and that you will agree with my argument for
>the debian/gbp.conf setting.
If you intend to maintain this package in DPMT or PAPT, we have a standard
gbp.conf for the teams that doesn't include this, so it would be inappropriate.
In any case, it's the default for a format 3.0(Quilt) source package, so
there's no need for it anyway:
https://manpages.debian.org/testing/git-buildpackage/gbp-import-orig.1.en.html
Scott K
