Hello all, I would be very grateful if someone could review my pydbus package:
https://anonscm.debian.org/cgit/python-modules/packages/pydbus.git/ Once it gets to a shape good enough to be uploaded, I will also need a sponsor for it. Some comments for the reviewer(s): Orig is from GitHub [1] where upstream tags its releases. Upstream also publishes it on PyPI, but the package there is less complete (the one released on GitHub has more docs). This has the effect of not having egg-info in the source package. As it gets generated on the package build, I added a dh_clean override to delete it, but I am not sure this is the way to go. [1] https://github.com/LEW21/pydbus/releases Upstream sources lack a copyright notice. The license (LGPL-2.1+) is clearly stated in the README file [2] but it has no copyright notice telling who is the copyright holder. I have used the one that appears as author in the setup.py (an hence in PyPI), also author of the commits on GitHub. At least of commits before september 2016, because, strange enough, author seems to have changed his first name and email and commits since september 2016 appear under his new name (which matches the name that currently appears on his GitHub account [3]). I have emailed the author to ask for clarification, and event sent a pull request [4] upstream fixing the README file, but have not received any answer yet. For now I am sticking to the author info as it appears in setup.py. [2] https://anonscm.debian.org/cgit/python-modules/packages/pydbus.git/ tree/README.rst [3] https://github.com/LEW21 [4] https://github.com/LEW21/pydbus/pull/37 I have included .pyremove files to get rid of tests and examples in the module packages. In the examples case, because I include them in the -doc package. In the tests case, because they should be used when building the packages (and they are), but I guess it is better not to ship them along with the library (correct me if I am wrong). There is a directory named "signal-spammer" with some C++ code. I have not included it in the binary packages because it is just for testing purposes during development. Upstream neither includes it in the PyPI package, nor calls it in his tests runner script. Thank you very much in advance. Best regards, -- Alberto Caso Palomino Servicio de Implantación de Sistemas Dirección Gral. de Admón. Electrónica y TI Consejería de Hacienda y Administración Pública Junta de Extremadura