On Sat, Feb 4, 2012 at 18:08, Jonas Genannt <jonas.gena...@capi2name.de> wrote: > Hello, > > I'm searching an sponsor for the python-carbon package. This package is > required for Graphite (http://graphite.wikidot.com/).
Since i'm interested in graphite, here's a quick review: general - package name: is it more a module or a program (ie, how a general user is supposed to use the package)? if the former, the package name it's ok, else it should be changed (and moved to PAPT). - there are some lintian warnings: how have you addressed them? - the package install a plugin directly into twisted dir: are you sure this is the correct way to do that? debian/control - add Vcs-* fields - missing X-Python-Version field - improve long description: knowing the server listens on port 2003 (and stuff like that) it's not the purpose of the description debian/rules - why all those file/directory tests? debian/README.Debian - small grammar fixes: '...to configure carbon, copy..."; s/Than/Then debian/python-carbon.examples - why not installing the configuration files in the right directory, /etc, instead of as examples the user has to copy by-hand? in any case, the user has to change default settings to start the server. debian/python-carbon.dirs - why configuring dir in a namespace not for python-carbon (namely /var/lib/graphite*)? debian/python-carbon.postinst - why is this script taking care of creating "Graphite User" Regards, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/capdtaj161ph4f2b0tzlaxzy23ey45v5zonhbn0cy93pzhcp...@mail.gmail.com
