Hi Niels, Thank you for a review. I'm adding debian-pyt...@l.d.o because this package is python related. I would be grateful if somebody from DMPT or PAPT could check this package.
On Sat, Dec 11, 2010 at 11:29 AM, Niels Thykier <ni...@thykier.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 2010-12-08 02:25, Janos Guljas wrote: >> Dear mentors, >> >> I am looking for a sponsor for my package "disco". >> >> [...] >> >> Kind regards >> Janos Guljas >> >> > > Hi again, > > Sorry for not getting back to you earlier[1]. > > [quote] >> >> Why do disco-master Pre-Depends on python-disco? I see nothing in the >> preinst script that suggests that python-disco must be present before >> disco-master is unpacked. > > Python module "disco" is needed for starting python-master. > Python-setuptools on disco python module must be triggered before > running /etc/init.d/disco-master start, which is done after installing > python-disco. Trying to start disco-master before configuring > python-disco package will fail. > [/quote] > > You only need a Pre-Depends if you are starting disco-master in the > preinst script (which does not make sense, since the package has yet to > be unpacked at that point). > If a package A depends on B, then the postinst script of B will always > be run before the postinst of A. > > If you can avoid Pre-Depending then please do, since the strength of the > dependency makes some difficult and you need approval to do it. Thanks for clearing that out. Pre-Depends is removed from disco-master. > > [qoute] >> It fails to build from source if Build-Depends-Indep are not satisfied >> when dpkg-buildpackage is invoked with -B: >> [...] >> sphinx-build -b html -d .build/doctrees . .build/html >> make[2]: sphinx-build: Command not found >> [...] >> >> This is how auto-builders will build your package. As I recall the >> debian-policy is disagreeing with reality here. I believe there is an >> attempt to make these two agree, but for now your package must be able >> to build without Build-Depends-Indep when dpkg-buildpackage is passed -B. > > Are you suggesting to move references from: > Build-Depends-Indep: python-sphinx, libjs-jquery > to Build-Depends? > > With that set, cowbuilder --build disco_0.3.1-1.dsc --buildresult . > - --binary-arch is building packages fine. But I do not understand the > reason for -B option in autobuild scripts. Do you have some references > that can clarify reason for it. Until now, I tested packages without > - --binary-arch build. I see now that this is a requirement. > [/quote] > > Moving those packages (as you now have done) to Build-Depends is one > solution. > > You should be able reproduce the original issue by moving them back to > Build-Depends-Indep and running cowbuilder with --debbuildopts "-B". True. I tested with -B and the build fails with Build-Depends-Indep field. I'll leave all dependencies in Build-Depends, for now. Source files with that changed are in http://mentors.debian.net/debian/pool/main/d/disco/. > > [quote] >> >> Have you contacted (or considered to contact) the python application >> team about team maintaining the package? (See [1] for more info). > > Yes, but I am not sure is this belongs to DMPT or PAPT. There are > modules and application packages... > > [/quote] > > Have you tried contacting any of the teams? Either team should be able > to help you (at least by telling you, that you should contact the other > team). Again I am not really into Python, so I cannot do much for you here. + debian-pyt...@l.d.o :-) > > Once again, sorry for the late reply. Another time, feel free to ping me > privately if I do not reply to you within 4 days. :) > > ~Niels > > [1] http://lists.debian.org/debian-mentors/2010/10/msg00213.html > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQIcBAEBCAAGBQJNA1J/AAoJEAVLu599gGRCbtAQAIXUixlPcgpRXOqZwQlWFQf+ > EqGBKiisv6cQtfzLikiwe94DO4UXkeUXqiUYNwx7A6liIeqT6vtcEHboMa0W8ALk > QupNn1Kt9IVLqgi51NZh6KB+vveYNo8xL4B++zwiq8GGd0+W2Ul8X2/eGascXrbl > coQO+uQ2MbpMWhTMS+Af4SUzJ9KHv8QFJfUwqxI244u188tUNCiujOoc3aiwayUO > 7LZKQm8BruPnAVinIUjQ/I/bE6CBQ8ir5C4y/DEXq2Oa22YI1eci5XKkjchvxqtU > XRDnuTgiZ07Xw+iHwkCflZ5utHofiueloOTNZ1oP/hnSqi9Cd0zb7bRhXDaVAlXz > B1jKGyhBk4jUI0hbc+735XKNmUgutFz8TrpZsWpJsjDPqANlFckQiV1IBI+pWN47 > 6SNOp93FhGaPr7gANKmHLLXToQnNE18aLYA2cvS0ksEQBg18cE/UtEHX6IH4HLol > r5novmJD+BWbzhoahTqOihdAdX3CsOAEvKtB5YDlK+54AJJYQeeJd5LYEiHSCXdw > E4ZBKo95Q4Bl/w0HiYGwI5rCri6JwNRjxxiZ0LDdCLDvv+GRi39LpX/SMbd/0s6L > z5carlQGPfCT4x34bqkIdMfLtPqKjBPbrjVkp4VEnyQtJgzLyXPUnKuUIAdhtEDu > z5Wuk1mbkBWnoBwK6Buj > =Imx0 > -----END PGP SIGNATURE----- > Best, Janos -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktikonwophaqfc+xoqfr7i5r-3psyp1ipdyb5g...@mail.gmail.com
