On Fri, Apr 02, 2010 at 07:11:55AM -0500, Michael Shuler wrote: > I would enjoy some feedback from the python team on this package, if > someone has a bit of time to review my work.
I can't sponsor your work, but a brief review. There are just a couple of things outstanding from a Python point of view, unless other team members disagree: You need to build-depend on python-support >= 0.90 for Python 2.6 support. debian/pycompat is for python-central, please use debian/pyversions. Does the module really work with all 2.x versions, or should it be increased to 2.4-? See /usr/share/python-support/README.gz for debian/pyversions format. The quickest way to get it sponsored, when these are changed, is to inject the package into python-modules svn and add the package to /topic in #debian-python. See http://wiki.debian.org/Teams/PythonModulesTeam -- Jonathan Wiltshire 1024D: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
signature.asc
Description: Digital signature