Luca Falavigna wrote:

> Is module useful without transmission-daemon (or transmission)? I think
> it should be put into Recommends at least.

OK. I've put it into Recommends.

> Some other issues:
> 
> * Upstream tarball is packed in a strange way. I use
>     uscan --force-download --repack doeproduce
>   and I'm unable to obtain a regular .orig.tar.gz. Can this be solved?

I've fixed debian/watch to look for .zip archives. In this case .orig.tar.gz 
downloads correctly.

> * debian/docs: No need to include README.source in .deb file.

Fixed.

> * debian/rules: use "install -Dm 755" instead of cp, so you can also set
>   permissions to have a working executable, this let you removing
>   dirs file too.

Fixed.

> * debian/rules: remove unused helper calls (such as dh_link).

Fixed.

> * [COSMETIC] Remove useless comments in your patches to keep it minimal:
>      #! /bin/sh /usr/share/dpatch/dpatch-run
>      ## 01_setup.dpatch by Timur Birsh <t...@linukz.org>
>      ## DP: Use distutils

Fixed.

Please find fixed package at [1].

1. 
http://mentors.debian.net/debian/pool/main/t/transmissionrpc/transmissionrpc_0.3-1.dsc

Thanks,
-- 
Timur


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to